From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>, Jeff Liu <jeff.liu@oracle.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: remote attribute overwrite causes transaction overrun
Date: Tue, 22 Apr 2014 22:04:58 -0500 [thread overview]
Message-ID: <53572DDA.8080302@sandeen.net> (raw)
In-Reply-To: <20140423000042.GO18672@dastard>
On 4/22/14, 7:00 PM, Dave Chinner wrote:
> On Wed, Apr 23, 2014 at 09:46:28AM +1000, Dave Chinner wrote:
>> On Tue, Apr 22, 2014 at 08:00:55PM +0800, Jeff Liu wrote:
>>>
>>> On 04/22 2014 14:59 PM, Dave Chinner wrote:
...
>>>> + /* remote value might be different size to the buffer supplied. */
>>>> + if (args->rmtvaluelen = args->valuelen)
>>> ^^^
>>> Here is a typo...
>>
>> Oh, well spotted.
>>
>> But, hold on a minute, shouldn't gcc be catching those sorts of
>> typos?
>>
>> /me groans
>>
>> $ gcc t.c
>> $ gcc -Wall t.c
>> t.c: In function ¿main¿:
>> t.c:10:2: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
>> if (foo = bar)
>> ^
>> $
>>
>> Only if -Wparentheses is specified.
>>
>> Why the hell are we suppressing useful warnings on the kernel build?
>
> Hmmm - looks like I missed the output of the warning when I built
> against 3.15-rc2 because it was a rebuild the world and there's tons
> of output when that happens...
>
> <sigh>
>
> Time to add ccflags-y += -Werror to the makefile....
Probably only under a couple specific arches...? How are we for i.e.
stupid printf format warnings about long vs. longlong on 32/64 arches...?
Or maybe you can -Werror, -Wno$FOO?
-Eric
> Cheers,
>
> Dave.
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-23 3:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 6:59 [PATCH] xfs: remote attribute overwrite causes transaction overrun Dave Chinner
2014-04-22 12:00 ` Jeff Liu
2014-04-22 23:46 ` Dave Chinner
2014-04-23 0:00 ` Dave Chinner
2014-04-23 3:04 ` Eric Sandeen [this message]
2014-04-23 5:54 ` Dave Chinner
2014-04-23 2:13 ` Jeff Liu
2014-04-22 14:17 ` Brian Foster
2014-04-23 0:29 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2015-04-29 1:55 [RFC PATCH] " Sheng Yong
2015-04-29 1:55 ` [PATCH] " Sheng Yong
2015-04-29 7:43 ` Dave Chinner
2015-04-29 9:05 ` Sheng Yong
2015-05-02 18:36 ` Greg KH
2015-05-04 1:45 ` Sheng Yong
2015-05-04 3:34 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53572DDA.8080302@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.