From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU Date: Mon, 29 Feb 2016 12:29:13 +0100 Message-ID: <5357325.sBkT8ESvOS@wuerfel> References: <1456737553-496245-1-git-send-email-arnd@arndb.de> <2734684.OJWJHS6snX@wuerfel> <56D429F0.7010409@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56D429F0.7010409-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Robin Murphy Cc: Joerg Roedel , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger List-Id: iommu@lists.linux-foundation.org On Monday 29 February 2016 11:22:24 Robin Murphy wrote: > >>> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > >>> index b325954cf8f8..ea0998921702 100644 > >>> --- a/drivers/iommu/Kconfig > >>> +++ b/drivers/iommu/Kconfig > >>> @@ -341,6 +341,7 @@ config MTK_IOMMU > >>> bool "MTK IOMMU Support" > >>> depends on ARM || ARM64 > >>> depends on ARCH_MEDIATEK || COMPILE_TEST > >>> + select ARM_DMA_USE_IOMMU > >> > >> If going down this route, I'd be inclined to add an "if ARM" there, just > >> for clarity. > > > > That would run into the NEED_SG_DMA_LENGTH problem on other architectures > > that don't already set it, right? > > Sorry, I'm lost - wouldn't "depends on ARM || ARM64" make other > architectures moot? arm64 already has NEED_SG_DMA_LENGTH=y by default. > Nevermind, I didn't notice the dependency on the architecture. What is keeping us from having 'depends on ARM || ARM64 || COMPILE_TEST'? I assume it doesn't work yet, but it would be nice to get that done at some point so we can take advantage of automated build testing like coverity. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 29 Feb 2016 12:29:13 +0100 Subject: [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU In-Reply-To: <56D429F0.7010409@arm.com> References: <1456737553-496245-1-git-send-email-arnd@arndb.de> <2734684.OJWJHS6snX@wuerfel> <56D429F0.7010409@arm.com> Message-ID: <5357325.sBkT8ESvOS@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 29 February 2016 11:22:24 Robin Murphy wrote: > >>> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > >>> index b325954cf8f8..ea0998921702 100644 > >>> --- a/drivers/iommu/Kconfig > >>> +++ b/drivers/iommu/Kconfig > >>> @@ -341,6 +341,7 @@ config MTK_IOMMU > >>> bool "MTK IOMMU Support" > >>> depends on ARM || ARM64 > >>> depends on ARCH_MEDIATEK || COMPILE_TEST > >>> + select ARM_DMA_USE_IOMMU > >> > >> If going down this route, I'd be inclined to add an "if ARM" there, just > >> for clarity. > > > > That would run into the NEED_SG_DMA_LENGTH problem on other architectures > > that don't already set it, right? > > Sorry, I'm lost - wouldn't "depends on ARM || ARM64" make other > architectures moot? arm64 already has NEED_SG_DMA_LENGTH=y by default. > Nevermind, I didn't notice the dependency on the architecture. What is keeping us from having 'depends on ARM || ARM64 || COMPILE_TEST'? I assume it doesn't work yet, but it would be nice to get that done at some point so we can take advantage of automated build testing like coverity. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754405AbcB2Lbl (ORCPT ); Mon, 29 Feb 2016 06:31:41 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:57222 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752321AbcB2Lbj (ORCPT ); Mon, 29 Feb 2016 06:31:39 -0500 From: Arnd Bergmann To: Robin Murphy Cc: Joerg Roedel , Joerg Roedel , linux-arm-kernel@lists.infradead.org, Yong Wu , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU Date: Mon, 29 Feb 2016 12:29:13 +0100 Message-ID: <5357325.sBkT8ESvOS@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56D429F0.7010409@arm.com> References: <1456737553-496245-1-git-send-email-arnd@arndb.de> <2734684.OJWJHS6snX@wuerfel> <56D429F0.7010409@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:/KkIAWdOjKCvF+FDy0cWgNaAWADF2zbXYf0BUeZRT0KttiwJTzU 82mB0d0eQFBW9J3+A+eDxL9IPMrVSSlpFWf4rMC34QG08KKdXbRKWSB6YQB9zOTrRN/vQL8 lAVAEgkQ18nkuK41Luciz4V8OeYFitq0+eVbOybQizNaJ/WfwJl1jkinyrAZunNT7cEFRP3 cDRN4VRAemYv51PMtuh0Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:PD91l1/1a1A=:S2FRDXDGBZtBx8wgYvnf0h 9yWOl5aqFQG7h+oWkywb+k4GPIyd9EwCanNIKDooBDUHWdWLsf3x817zm+8tWnfkOt6/t1CHZ qL+w0e3ShbIS7i9/nrD288wHaWWyTGnlb/9Vigy6+CrebxMY+n+teC3aw/gZuKDEhD4kXbV0B fl37pg2ChcPQfkaOF4sQQTesKPbJeZf1TX1FXbh8Hg+5WUDUw+HXpemTiNtmXfX5LB3sC5WEP 1ttom+ULpfsO9IfM/jmXW1VAR5hhe/9g2SYkPb6Q3MIQWQ0BC4DhXPavZClpOswktEamR8jdc NY1ExHX45p3eqdp9UnOebqdGKv3tesbr4xO4MzleJ1YUZ9HuG99QB9opOWaS9tP9uUumlRlah eMSkPMzCnx21u0JL36/RLqlY6dui4a/sh48T8BPGCMKUx00t0l8QFlqRIKMfohgCWsKQye0lm rGU9V7lM7/5YqOsaDRDVYaRx5uj7+rtj9tRp2M3CHm8xGwssF/rPPA66G4dROYYwJmp17XS4w pyITdiLGvzR0EDHJ3QkEyoHB6e+8F5IjqchioRGbl9zk3ks+PaqKM6pYirFXElpjbm2OTfPRJ IFmOmhgXvjKqbp5oNG/RIjmN1rink1gjp57fIqqSj1ubVxLOwRZzYNTUq9gPujYuoAOoEUHpD sBfJlWD8DA6L2Mps1bLVqUYnzn4YD0k75tqeXiWzRvkOz8ca/XFtX/hUrmMivYuN5jyyCEzoV SUYPn06JZHtFmI2n Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 29 February 2016 11:22:24 Robin Murphy wrote: > >>> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > >>> index b325954cf8f8..ea0998921702 100644 > >>> --- a/drivers/iommu/Kconfig > >>> +++ b/drivers/iommu/Kconfig > >>> @@ -341,6 +341,7 @@ config MTK_IOMMU > >>> bool "MTK IOMMU Support" > >>> depends on ARM || ARM64 > >>> depends on ARCH_MEDIATEK || COMPILE_TEST > >>> + select ARM_DMA_USE_IOMMU > >> > >> If going down this route, I'd be inclined to add an "if ARM" there, just > >> for clarity. > > > > That would run into the NEED_SG_DMA_LENGTH problem on other architectures > > that don't already set it, right? > > Sorry, I'm lost - wouldn't "depends on ARM || ARM64" make other > architectures moot? arm64 already has NEED_SG_DMA_LENGTH=y by default. > Nevermind, I didn't notice the dependency on the architecture. What is keeping us from having 'depends on ARM || ARM64 || COMPILE_TEST'? I assume it doesn't work yet, but it would be nice to get that done at some point so we can take advantage of automated build testing like coverity. Arnd