From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH v2 3/4] amd-iommu: disable iommu_hap_pt_share with AMD IOMMUs Date: Wed, 23 Apr 2014 12:04:12 +0200 Message-ID: <5357901C.8080705@citrix.com> References: <1398240984-67266-1-git-send-email-roger.pau@citrix.com> <1398240984-67266-4-git-send-email-roger.pau@citrix.com> <5357AABB020000780000B497@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Wcu2M-0004ON-0W for xen-devel@lists.xenproject.org; Wed, 23 Apr 2014 10:04:21 +0000 In-Reply-To: <5357AABB020000780000B497@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, Xiantao Zhang , Suravee Suthikulpanit List-Id: xen-devel@lists.xenproject.org On 23/04/14 11:57, Jan Beulich wrote: >>>> On 23.04.14 at 10:16, wrote: >> According to the comment in p2m.h, AMD IOMMUs don't work correctly >> with page types different than p2m_ram_rw when the p2m is shared >> between HAP and IOMMU, so disable this sharing when using AMD IOMMUs. > > Doesn't this need to go before patch 2? It could certainly go before patch 2, but I don't see such a hard requirement in the ordering (either way AMD hardware needs both patches to work correctly, and applying one before the other is not going to break bisection AFAICT). Roger.