From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86: add missing break in hwdom_pit_access() Date: Wed, 23 Apr 2014 11:56:23 +0100 Message-ID: <53579C57.8030007@citrix.com> References: <53577E61020000780000B21F@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5652992125906094344==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Wcuqw-0004XA-Jp for xen-devel@lists.xenproject.org; Wed, 23 Apr 2014 10:56:35 +0000 In-Reply-To: <53577E61020000780000B21F@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Keir Fraser List-Id: xen-devel@lists.xenproject.org --===============5652992125906094344== Content-Type: multipart/alternative; boundary="------------080002040505070705050201" --------------080002040505070705050201 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 23/04/14 07:48, Jan Beulich wrote: > Coverity ID 1203045 > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper > > --- a/xen/arch/x86/time.c > +++ b/xen/arch/x86/time.c > @@ -1634,6 +1634,7 @@ int hwdom_pit_access(struct ioreq *ioreq > outb(ioreq->data, PIT_MODE); > return 1; > } > + break; > > case 0x61: > if ( ioreq->dir == IOREQ_READ ) > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --------------080002040505070705050201 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit
On 23/04/14 07:48, Jan Beulich wrote:
Coverity ID 1203045

Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>


--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -1634,6 +1634,7 @@ int hwdom_pit_access(struct ioreq *ioreq
             outb(ioreq->data, PIT_MODE);
             return 1;
         }
+        break;
 
     case 0x61:
         if ( ioreq->dir == IOREQ_READ )






_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--------------080002040505070705050201-- --===============5652992125906094344== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5652992125906094344==--