All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Lingfei Kong <lkong@redhat.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: drjones@redhat.com, vkuznets@redhat.com, leiwang@redhat.com, wshi@redhat.com
Date: Wed, 23 Apr 2014 11:58:36 +0100	[thread overview]
Message-ID: <53579CDC.1050605@eu.citrix.com> (raw)
In-Reply-To: <53570FCF.9050708@redhat.com>

On 04/23/2014 01:56 AM, Lingfei Kong wrote:
> On 04/22/2014 06:59 PM, George Dunlap wrote:
>> On Fri, Apr 18, 2014 at 2:40 AM, Lingfei Kong <lkong@redhat.com> wrote:
>>> Hello,
>>> When i create a guest with option 'cpus="0-3"' on the command line, xl can not parse the config. But it works well when i specify 'cpus=1' on the command line. I read the man page xl.cfg, learned that xl support the following format:
>>> "0-3,5,^1"
>>> so  it would be very nice if xl can support this format on the command line too.
>>>
>>> Also i have file a bug on bugzilla: Bug 1886 - option `cpus="0-3"` works well when you specify it in a configure file, but it give a error feadback when you add it to the command line
>>>
>>>
>>>
>>> The following are the  details:
>>>
>>> Description of problem:
>>> option `cpus="0-3"` works well when you specify it in a configure file, but it give a error feadback when you add it to the command line.
>>>
>>> Version-Release number of selected component (if applicable):
>>>
>>> How reproducible:
>>> 100%
>>>
>>> Steps to Reproduce:
>>> 1. Install a host with xen4
>>> 2. Create a guest, add option 'cpus="0-3"' on the command line
>>> # xl -v create hvm-7.0-64-1.cfg cpus="0-3"
>>> Parsing config from hvm-7.0-64-1.cfg
>>> hvm-7.0-64-1.cfg:28: config parsing error near `-3': lexical error
>>> warning: Config file looks like it contains Python code.
>>> warning:  Arbitrary Python is no longer supported.
>>> warning:  See http://wiki.xen.org/wiki/PythonInXlConfig
>>> Failed to parse config: Invalid argument
>> The problem here is that your shell is discarding the quotes; so what
>> xl sees is 'cpus=0-3', not 'cpus="0-3"'.  Try the following:
>>
>> # xl -v create hvm-7.0-64-1.cfg cpus=\"0-3\"
>>
>> -George
>>
> Hi George,
> Thanks for your hlep. It works with cpus=\"0-3\".

Actually, a better way would be to enclose the whole thing in single 
quotes, and separate variables with a ; like so:

# xl -v create hvm.cfg 'cpus="0-3"; memory=2048'

This should at very least be documented better -- I'll send a patch to 
update the xl man page.

  -George

  reply	other threads:[~2014-04-23 10:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <648058658.7316781.1397784467480.JavaMail.zimbra@redhat.com>
2014-04-18  1:40 ` drjones@redhat.com, vkuznets@redhat.com, leiwang@redhat.com, wshi@redhat.com Lingfei Kong
2014-04-21 13:02   ` Is: Xen 4.4 and 'cpus="X-Y" command line parsing borked Was:Re: " Konrad Rzeszutek Wilk
2014-04-22  1:33     ` Lingfei Kong
2014-04-22 10:59   ` George Dunlap
2014-04-23  0:56     ` Lingfei Kong
2014-04-23 10:58       ` George Dunlap [this message]
2014-04-24  0:14         ` Lingfei Kong
2014-04-24  8:44           ` Ian Campbell
2014-04-24  9:01             ` George Dunlap
2014-04-24  9:32               ` Ian Campbell
2014-04-24 11:27                 ` George Dunlap
2014-04-24 11:33                   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53579CDC.1050605@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=lkong@redhat.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.