From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Cousson Subject: Re: [PATCH RFC] ARM: dts: am335x: update USB DT references Date: Wed, 23 Apr 2014 17:35:29 +0200 Message-ID: <5357DDC1.1070609@baylibre.com> References: <1397647595-10927-1-git-send-email-leigh@solinno.co.uk> <5356794C.7070707@baylibre.com> <20140423144822.GA4833@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wg0-f41.google.com ([74.125.82.41]:63983 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbaDWPfd (ORCPT ); Wed, 23 Apr 2014 11:35:33 -0400 Received: by mail-wg0-f41.google.com with SMTP id n12so1036823wgh.12 for ; Wed, 23 Apr 2014 08:35:32 -0700 (PDT) In-Reply-To: <20140423144822.GA4833@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: Leigh Brown , Mugunthan V N , devicetree@vger.kernel.org, Sebastian Andrzej Siewior , Felipe Balbi , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi Tony, On 23/04/2014 16:48, Tony Lindgren wrote: > * Benoit Cousson [140422 07:14]: >> Hi Leigh, >> >> On 16/04/2014 13:26, Leigh Brown wrote: >>> In "ARM: dts: am33xx: correcting dt node unit address for usb", the >>> usb_ctrl_mod and cppi41dma nodes were updated with the correct regi= ster >>> addresses. However, the dts files that reference these nodes were = not >>> updated, and those devices are no longer being enabled. >>> >>> This patch corrects the references for the affected dts files. >> >> Thanks for the fix. BTW, why is it a RFC? Do you plan to send an upd= ated >> version? >> >> FYI, even with this fix, the BBB still does not have a working MUSB = on >> 3.15-rc2. Have you observed that as well? >> >>> Signed-off-by: Leigh Brown >> >> If this is a final version, I'll apply it for -rc3. > > Looks like I already have this in omap-for-v3.15/fixes-v2, sorry > looks like I never replied to this one. :-) OK, I'll let you handle this one. Thanks, Benoit > > Regards, > > Tony > >>> --- >>> arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++-- >>> arch/arm/boot/dts/am335x-evm.dts | 4 ++-- >>> arch/arm/boot/dts/am335x-evmsk.dts | 4 ++-- >>> arch/arm/boot/dts/am335x-igep0033.dtsi | 4 ++-- >>> 4 files changed, 8 insertions(+), 8 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/b= oot/dts/am335x-bone-common.dtsi >>> index e3f27ec..2e7d932 100644 >>> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi >>> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi >>> @@ -183,7 +183,7 @@ >>> &usb { >>> status =3D "okay"; >>> >>> - control@44e10000 { >>> + control@44e10620 { >>> status =3D "okay"; >>> }; >>> >>> @@ -204,7 +204,7 @@ >>> dr_mode =3D "host"; >>> }; >>> >>> - dma-controller@07402000 { >>> + dma-controller@47402000 { >>> status =3D "okay"; >>> }; >>> }; >>> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/a= m335x-evm.dts >>> index 28ae040..77df10d 100644 >>> --- a/arch/arm/boot/dts/am335x-evm.dts >>> +++ b/arch/arm/boot/dts/am335x-evm.dts >>> @@ -331,7 +331,7 @@ >>> &usb { >>> status =3D "okay"; >>> >>> - control@44e10000 { >>> + control@44e10620 { >>> status =3D "okay"; >>> }; >>> >>> @@ -352,7 +352,7 @@ >>> dr_mode =3D "host"; >>> }; >>> >>> - dma-controller@07402000 { >>> + dma-controller@47402000 { >>> status =3D "okay"; >>> }; >>> }; >>> diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts= /am335x-evmsk.dts >>> index ec08f6f..ab23885 100644 >>> --- a/arch/arm/boot/dts/am335x-evmsk.dts >>> +++ b/arch/arm/boot/dts/am335x-evmsk.dts >>> @@ -364,7 +364,7 @@ >>> &usb { >>> status =3D "okay"; >>> >>> - control@44e10000 { >>> + control@44e10620 { >>> status =3D "okay"; >>> }; >>> >>> @@ -385,7 +385,7 @@ >>> dr_mode =3D "host"; >>> }; >>> >>> - dma-controller@07402000 { >>> + dma-controller@47402000 { >>> status =3D "okay"; >>> }; >>> }; >>> diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi b/arch/arm/boot= /dts/am335x-igep0033.dtsi >>> index 7063311..5942e7d 100644 >>> --- a/arch/arm/boot/dts/am335x-igep0033.dtsi >>> +++ b/arch/arm/boot/dts/am335x-igep0033.dtsi >>> @@ -202,7 +202,7 @@ >>> &usb { >>> status =3D "okay"; >>> >>> - control@44e10000 { >>> + control@44e10620 { >>> status =3D "okay"; >>> }; >>> >>> @@ -223,7 +223,7 @@ >>> dr_mode =3D "host"; >>> }; >>> >>> - dma-controller@07402000 { >>> + dma-controller@47402000 { >>> status =3D "okay"; >>> }; >>> }; >>> >> >> >> -- >> Beno=C3=AEt Cousson >> BayLibre >> Embedded Linux Technology Lab >> www.baylibre.com --=20 Beno=C3=AEt Cousson BayLibre Embedded Linux Technology Lab www.baylibre.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: bcousson@baylibre.com (Benoit Cousson) Date: Wed, 23 Apr 2014 17:35:29 +0200 Subject: [PATCH RFC] ARM: dts: am335x: update USB DT references In-Reply-To: <20140423144822.GA4833@atomide.com> References: <1397647595-10927-1-git-send-email-leigh@solinno.co.uk> <5356794C.7070707@baylibre.com> <20140423144822.GA4833@atomide.com> Message-ID: <5357DDC1.1070609@baylibre.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Tony, On 23/04/2014 16:48, Tony Lindgren wrote: > * Benoit Cousson [140422 07:14]: >> Hi Leigh, >> >> On 16/04/2014 13:26, Leigh Brown wrote: >>> In "ARM: dts: am33xx: correcting dt node unit address for usb", the >>> usb_ctrl_mod and cppi41dma nodes were updated with the correct register >>> addresses. However, the dts files that reference these nodes were not >>> updated, and those devices are no longer being enabled. >>> >>> This patch corrects the references for the affected dts files. >> >> Thanks for the fix. BTW, why is it a RFC? Do you plan to send an updated >> version? >> >> FYI, even with this fix, the BBB still does not have a working MUSB on >> 3.15-rc2. Have you observed that as well? >> >>> Signed-off-by: Leigh Brown >> >> If this is a final version, I'll apply it for -rc3. > > Looks like I already have this in omap-for-v3.15/fixes-v2, sorry > looks like I never replied to this one. :-) OK, I'll let you handle this one. Thanks, Benoit > > Regards, > > Tony > >>> --- >>> arch/arm/boot/dts/am335x-bone-common.dtsi | 4 ++-- >>> arch/arm/boot/dts/am335x-evm.dts | 4 ++-- >>> arch/arm/boot/dts/am335x-evmsk.dts | 4 ++-- >>> arch/arm/boot/dts/am335x-igep0033.dtsi | 4 ++-- >>> 4 files changed, 8 insertions(+), 8 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi >>> index e3f27ec..2e7d932 100644 >>> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi >>> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi >>> @@ -183,7 +183,7 @@ >>> &usb { >>> status = "okay"; >>> >>> - control at 44e10000 { >>> + control at 44e10620 { >>> status = "okay"; >>> }; >>> >>> @@ -204,7 +204,7 @@ >>> dr_mode = "host"; >>> }; >>> >>> - dma-controller at 07402000 { >>> + dma-controller at 47402000 { >>> status = "okay"; >>> }; >>> }; >>> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts >>> index 28ae040..77df10d 100644 >>> --- a/arch/arm/boot/dts/am335x-evm.dts >>> +++ b/arch/arm/boot/dts/am335x-evm.dts >>> @@ -331,7 +331,7 @@ >>> &usb { >>> status = "okay"; >>> >>> - control at 44e10000 { >>> + control at 44e10620 { >>> status = "okay"; >>> }; >>> >>> @@ -352,7 +352,7 @@ >>> dr_mode = "host"; >>> }; >>> >>> - dma-controller at 07402000 { >>> + dma-controller at 47402000 { >>> status = "okay"; >>> }; >>> }; >>> diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts >>> index ec08f6f..ab23885 100644 >>> --- a/arch/arm/boot/dts/am335x-evmsk.dts >>> +++ b/arch/arm/boot/dts/am335x-evmsk.dts >>> @@ -364,7 +364,7 @@ >>> &usb { >>> status = "okay"; >>> >>> - control at 44e10000 { >>> + control at 44e10620 { >>> status = "okay"; >>> }; >>> >>> @@ -385,7 +385,7 @@ >>> dr_mode = "host"; >>> }; >>> >>> - dma-controller at 07402000 { >>> + dma-controller at 47402000 { >>> status = "okay"; >>> }; >>> }; >>> diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi b/arch/arm/boot/dts/am335x-igep0033.dtsi >>> index 7063311..5942e7d 100644 >>> --- a/arch/arm/boot/dts/am335x-igep0033.dtsi >>> +++ b/arch/arm/boot/dts/am335x-igep0033.dtsi >>> @@ -202,7 +202,7 @@ >>> &usb { >>> status = "okay"; >>> >>> - control at 44e10000 { >>> + control at 44e10620 { >>> status = "okay"; >>> }; >>> >>> @@ -223,7 +223,7 @@ >>> dr_mode = "host"; >>> }; >>> >>> - dma-controller at 07402000 { >>> + dma-controller at 47402000 { >>> status = "okay"; >>> }; >>> }; >>> >> >> >> -- >> Beno?t Cousson >> BayLibre >> Embedded Linux Technology Lab >> www.baylibre.com -- Beno?t Cousson BayLibre Embedded Linux Technology Lab www.baylibre.com