From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] [media] V4L: s5c73m3: Fix build after v4l2_of_get_next_endpoint rename
Date: Wed, 23 Apr 2014 23:46:07 +0200 [thread overview]
Message-ID: <5358349F.7090003@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1404231354370.1281@chino.kir.corp.google.com>
On 04/23/2014 10:57 PM, David Rientjes wrote:
> On Wed, 9 Apr 2014, Krzysztof Kozlowski wrote:
>
>> Fix build error after v4l2_of_get_next_endpoint rename (fd9fdb78a9bf:
>> "[media] of: move graph helpers from drivers/media/v4l2-core..."):
>>
>> drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function ‘s5c73m3_get_platform_data’:
>> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:2: error: implicit declaration of function ‘v4l2_of_get_next_endpoint’ [-Werror=implicit-function-declaration]
>> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:10: warning: assignment makes pointer from integer without a cast [enabled by default]
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
>> index a4459301b5f8..ee0f57e01b56 100644
>> --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
>> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
>> @@ -1616,7 +1616,7 @@ static int s5c73m3_get_platform_data(struct s5c73m3 *state)
>> if (ret < 0)
>> return -EINVAL;
>>
>> - node_ep = v4l2_of_get_next_endpoint(node, NULL);
>> + node_ep = of_graph_get_next_endpoint(node, NULL);
>> if (!node_ep) {
>> dev_warn(dev, "no endpoint defined for node: %s\n",
>> node->full_name);
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> The build error that this patch fixes is still present in Linus's tree,
> and there's been no response to it in two weeks. Any chance of this
> getting merged?
I expect a patch fixing this issue to be sent in next batch of the media
fixes from Mauro. It has been queued in the media tree:
http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?h=fixes&id=41f484d12c0105ce01ea79acdc094fff9124491b
Thanks,
Sylwester
prev parent reply other threads:[~2014-04-23 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 11:54 [PATCH] [media] V4L: s5c73m3: Fix build after v4l2_of_get_next_endpoint rename Krzysztof Kozlowski
2014-04-23 20:57 ` David Rientjes
2014-04-23 21:46 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5358349F.7090003@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=a.hajda@samsung.com \
--cc=grant.likely@linaro.org \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=rientjes@google.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.