From mboxrd@z Thu Jan 1 00:00:00 1970 From: chenweilong Subject: Re: [patch net-next] vlan: Don't allow vlan devices to change network namespaces. Date: Thu, 24 Apr 2014 08:59:51 +0800 Message-ID: <53586207.7060407@huawei.com> References: <1398170586-6668-1-git-send-email-chenweilong@huawei.com> <1398176819.29946.49.camel@edumazet-glaptop2.roam.corp.google.com> <5357280C.1000404@huawei.com> <53576A6F.2020207@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: , , To: , Eric Dumazet Return-path: Received: from szxga02-in.huawei.com ([119.145.14.65]:14572 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbaDXBAW (ORCPT ); Wed, 23 Apr 2014 21:00:22 -0400 In-Reply-To: <53576A6F.2020207@6wind.com> Sender: netdev-owner@vger.kernel.org List-ID: On 2014/4/23 15:23, Nicolas Dichtel wrote: > Le 23/04/2014 04:40, chenweilong a =C3=A9crit : >> On 2014/4/22 22:26, Eric Dumazet wrote: >>> On Tue, 2014-04-22 at 20:43 +0800, Chen Weilong wrote: >>>> From: Weilong Chen >>>> >>>> Like bonding, vlan as netdevice doesn't cross netns boundaries. >>>> >>>> Vlan port and vlan itself live in same netns. >>> >>> Please explain why you believe it should be like that. >>> >>> bonding and vlan have quite different purpose, so your changelog is >>> quite obscure. >>> >>> We had a discussion like this one with macvlan, and prior patch was >>> rejected. >>> >>> >>> >>> >> This idea comes from the different result of two changing namespace = orders. >> Test on eth1 and its vlan eth1.5, move them form default ns to a new= ns called net0. >> 1.move eth1 first,and then eth1.5; >> 2.move eth1.5 first, and then eth1; >> As a network manager, I will be happy they both work, I don't care a= bout the orders. >> But, 1) doesn't work, if eth1 was moved to other ns, all related vla= ns were unregisted. >> you need to create a new eth1.5 in net0. >> And, 2) is not safe, if someone forgets to move eth1, eth1.5 will no= t work, making >> things complex. > We have to fix this case, because it is a valid use case to have eth1= =2E5 in net0 > and eth1 in another ns. >=20 eth1.5 can receive and send packets in net0, the problem is you can't a= dd a new eth1.5 in old ns, report 'error: File exists'. >> >> So what's the better order ? >> I prefer 1), when a vlan dev is setup, it has a namespace, and belon= gs to it, >> When somebody moves it, it should say 'hey boy, don't move me,I like= here :0' >> >> Thanks, >> Weilong > --=20 > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >=20 >=20