All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 1/2] mkimage: add atmelimage
Date: Thu, 24 Apr 2014 07:23:59 +0200	[thread overview]
Message-ID: <53589FEF.5050008@googlemail.com> (raw)
In-Reply-To: <53588058.5050900@atmel.com>

Hi Bo,

On 24.04.14 05:09, Bo Shen wrote:
> Hi Andreas,
> 
> On 04/23/2014 10:29 PM, Andreas Bie?mann wrote:
>> +static void atmel_set_header(void *ptr, struct stat *sbuf, int ifd,
>> +                struct image_tool_params *params)
>> +{
>> +    /* just save the image size into 6'th interrupt vector */
>> +    uint32_t *ints = (uint32_t *)ptr;
>> +
>> +    /* The size must not exceed 64 Kbytes */
>> +    if (sbuf->st_size < 64 * 1024)
>> +        ints[5] = sbuf->st_size;
>> +}
> 
> Here, just a reminder.
> 
> As only sama5d3xek support SPL, so it won't hurt. However, if plan to
> add other Atmel boards with SPL support, we need check it more strictly
> (e.g: sam9x5 only support up to 24k bytes).

Well, I'd like to have other devices also support SPL. I think we should
just remove that check here. We should use the linker for size checking.

Best regards

Andreas Bie?mann

  reply	other threads:[~2014-04-24  5:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23 14:29 [U-Boot] [RFC PATCH 0/2] Add atmel ROM code image Andreas Bießmann
2014-04-23 14:29 ` [U-Boot] [RFC PATCH 1/2] mkimage: add atmelimage Andreas Bießmann
2014-04-24  3:09   ` Bo Shen
2014-04-24  5:23     ` Andreas Bießmann [this message]
2014-04-23 14:29 ` [U-Boot] [RFC PATCH 2/2] arm:at91: enable ROM loadable atmel image Andreas Bießmann
2014-04-24  3:10   ` Bo Shen
2014-04-24  3:03 ` [U-Boot] [RFC PATCH 0/2] Add atmel ROM code image Bo Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53589FEF.5050008@googlemail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.