From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [patch net-next] vlan: Don't allow vlan devices to change network namespaces. Date: Thu, 24 Apr 2014 09:01:26 +0200 Message-ID: <5358B6C6.6010709@6wind.com> References: <1398170586-6668-1-git-send-email-chenweilong@huawei.com> <1398176819.29946.49.camel@edumazet-glaptop2.roam.corp.google.com> <5357280C.1000404@huawei.com> <53576A6F.2020207@6wind.com> <53586207.7060407@huawei.com> <20140424054734.GA16057@unicorn.suse.cz> Reply-To: nicolas.dichtel@6wind.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Eric Dumazet , kaber@trash.net, davem@davemloft.net, netdev@vger.kernel.org To: Michal Kubecek , chenweilong Return-path: Received: from mail-we0-f169.google.com ([74.125.82.169]:52987 "EHLO mail-we0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbaDXHBa (ORCPT ); Thu, 24 Apr 2014 03:01:30 -0400 Received: by mail-we0-f169.google.com with SMTP id u56so629148wes.28 for ; Thu, 24 Apr 2014 00:01:28 -0700 (PDT) In-Reply-To: <20140424054734.GA16057@unicorn.suse.cz> Sender: netdev-owner@vger.kernel.org List-ID: Le 24/04/2014 07:47, Michal Kubecek a =E9crit : > On Thu, Apr 24, 2014 at 08:59:51AM +0800, chenweilong wrote: >> On 2014/4/23 15:23, Nicolas Dichtel wrote: >>> Le 23/04/2014 04:40, chenweilong a =E9crit : >>>> And, 2) is not safe, if someone forgets to move eth1, eth1.5 will = not work, making >>>> things complex. >>> We have to fix this case, because it is a valid use case to have et= h1.5 in net0 >>> and eth1 in another ns. >>> >> eth1.5 can receive and send packets in net0, the problem is you can'= t add a new eth1.5 >> in old ns, report 'error: File exists'. > > And this is correct, as far as I can tell. If it was possible, which = of > the two interfaces would receive VLAN tagged packets with VID 5 comin= g > to eth1? I agree, this is the correct behavior.