Re: status in PACKET_RX_RING is actually a bit mask

[Daniel Borkmann <dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On 04/24/2014 10:04 AM, Michael Kerrisk (man-pages) wrote:
>> Now to your question. It can easily be seen from the if_packet.h header
>> file http://lingrok.org/xref/linux-net-next/include/uapi/linux/if_packet.h#93
>> that TP_STATUS_* are individual bits that are set in tp_status field.
>
> So, I take it that that's an Ack-for the patch by Stefan?

Feel free to add my Ack. One nit below:

diff --git a/man7/packet.7 b/man7/packet.7
index 1d3f222..6bac465 100644
--- a/man7/packet.7
+++ b/man7/packet.7
@@ -353,9 +353,9 @@ The packet socket owns all slots with status
  .BR TP_STATUS_KERNEL .
  After filling a slot, it changes the status of the slot to transfer
  ownership to the application.
-During normal operation, the new status is
-.BR TP_STATUS_USER ,
-to signal that a correctly received packet has been stored.
+During normal operation, the new status has the
+.BR TP_STATUS_USER
+bit set to signal that a correctly received packet has been stored.

^--- I would drop the 'correctly' here as it rather raises questions
      what 'incorrectly' would mean in this context.

  When the application has finished processing a packet, it transfers
  ownership of the slot back to the socket by setting the status to


>
> Cheers,
>
> Michael
>
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html