From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
sameo@linux.intel.com, nm@ti.com
Subject: Re: [RESEND 0/3] mfd: twl6040: Updates for i2s speed and fix for chip deadlock
Date: Thu, 24 Apr 2014 12:12:36 +0300 [thread overview]
Message-ID: <5358D584.6080206@ti.com> (raw)
In-Reply-To: <1396359901-32656-1-git-send-email-peter.ujfalusi@ti.com>
Lee,
On 04/01/2014 04:44 PM, Peter Ujfalusi wrote:
> Hi,
>
> While looking into a report by Florian Vaussard [1] I have noticed couple of most
> likely unrelated issues:
> - all boards using twl6040 configures the i2c bus to 400KHz while twl6040 is set
> to 100KHz as default.
> - if I set the audpwron GPIO high [2] in the bootloader the i2c communication towards
> twl6040 will be broken
> - got confirmation from HW design teams that twl6040 can work on a bus with
> 400KHz even if after hard reset but it is optimal to swithc to 400KHz mode as
> soon as possible.
>
> The solution or these are:
> set the twl6040 to i2c fast mode with regmap patch
> Clear the INTID register right after we request the audpwron GPIO and set it to
> low.
Do you want me to resend this series again?
Thanks,
Péter
>
> Generated on top of:
> git://git.linaro.org/people/lee.jones/mfd.git for-mfd-next
>
> Tested on PandaBoard, PandaBoardES, OMAP4-blaze (SDP)
>
> [1] http://www.spinics.net/lists/arm-kernel/msg310725.html
> [2] Command in u-boot to enable the audpwron on PandaBoards: gpio set 127
>
> Regards,
> Peter
> ---
> Peter Ujfalusi (3):
> mfd: twl6040: Select i2c fast mode as default with regmap patch
> mfd: twl6040: Move register patching earlier in probe
> mfd: twl6040: Clear the interrupt ID register before requesting IRQ
>
> drivers/mfd/twl6040.c | 19 +++++++++++++------
> include/linux/mfd/twl6040.h | 1 +
> 2 files changed, 14 insertions(+), 6 deletions(-)
>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <lee.jones@linaro.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<sameo@linux.intel.com>, <nm@ti.com>
Subject: Re: [RESEND 0/3] mfd: twl6040: Updates for i2s speed and fix for chip deadlock
Date: Thu, 24 Apr 2014 12:12:36 +0300 [thread overview]
Message-ID: <5358D584.6080206@ti.com> (raw)
In-Reply-To: <1396359901-32656-1-git-send-email-peter.ujfalusi@ti.com>
Lee,
On 04/01/2014 04:44 PM, Peter Ujfalusi wrote:
> Hi,
>
> While looking into a report by Florian Vaussard [1] I have noticed couple of most
> likely unrelated issues:
> - all boards using twl6040 configures the i2c bus to 400KHz while twl6040 is set
> to 100KHz as default.
> - if I set the audpwron GPIO high [2] in the bootloader the i2c communication towards
> twl6040 will be broken
> - got confirmation from HW design teams that twl6040 can work on a bus with
> 400KHz even if after hard reset but it is optimal to swithc to 400KHz mode as
> soon as possible.
>
> The solution or these are:
> set the twl6040 to i2c fast mode with regmap patch
> Clear the INTID register right after we request the audpwron GPIO and set it to
> low.
Do you want me to resend this series again?
Thanks,
Péter
>
> Generated on top of:
> git://git.linaro.org/people/lee.jones/mfd.git for-mfd-next
>
> Tested on PandaBoard, PandaBoardES, OMAP4-blaze (SDP)
>
> [1] http://www.spinics.net/lists/arm-kernel/msg310725.html
> [2] Command in u-boot to enable the audpwron on PandaBoards: gpio set 127
>
> Regards,
> Peter
> ---
> Peter Ujfalusi (3):
> mfd: twl6040: Select i2c fast mode as default with regmap patch
> mfd: twl6040: Move register patching earlier in probe
> mfd: twl6040: Clear the interrupt ID register before requesting IRQ
>
> drivers/mfd/twl6040.c | 19 +++++++++++++------
> include/linux/mfd/twl6040.h | 1 +
> 2 files changed, 14 insertions(+), 6 deletions(-)
>
next prev parent reply other threads:[~2014-04-24 9:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 13:44 [RESEND 0/3] mfd: twl6040: Updates for i2s speed and fix for chip deadlock Peter Ujfalusi
2014-04-01 13:44 ` Peter Ujfalusi
2014-04-01 13:44 ` [RESEND 1/3] mfd: twl6040: Select i2c fast mode as default with regmap patch Peter Ujfalusi
2014-04-01 13:44 ` Peter Ujfalusi
2014-04-28 10:42 ` Lee Jones
2014-04-01 13:45 ` [RESEND 2/3] mfd: twl6040: Move register patching earlier in probe Peter Ujfalusi
2014-04-01 13:45 ` Peter Ujfalusi
2014-04-28 10:42 ` Lee Jones
2014-04-01 13:45 ` [RESEND 3/3] mfd: twl6040: Clear the interrupt ID register before requesting IRQ Peter Ujfalusi
2014-04-01 13:45 ` Peter Ujfalusi
2014-04-28 10:43 ` Lee Jones
2014-04-24 9:12 ` Peter Ujfalusi [this message]
2014-04-24 9:12 ` [RESEND 0/3] mfd: twl6040: Updates for i2s speed and fix for chip deadlock Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5358D584.6080206@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.