From: Tushar Behera <tushar.behera@linaro.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-pm@vger.kernel.org, rui.zhang@intel.com,
eduardo.valentin@ti.com
Subject: Re: [PATCH] thermal: samsung: Only update available threshold limits
Date: Thu, 24 Apr 2014 17:00:28 +0530 [thread overview]
Message-ID: <5358F5D4.1010506@linaro.org> (raw)
In-Reply-To: <1705902.4858U1S3Zd@amdc1032>
On 04/24/2014 04:18 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Monday, April 14, 2014 11:08:15 AM Tushar Behera wrote:
>> Currently the threshold limits are updated in 2 stages, once for all
>> software trigger levels and again for hardware trip point.
>>
>> While updating the software trigger levels, it overwrites the threshold
>> limit for hardware trip point thereby forcing the Exynos core to issue
>> an emergency shutdown.
>
> On what SoC type have you encountered this problem? It doesn't seem to
> happen on older SoCs (at least Exynos4210 and Exynos4x12 ones).
>
I found this issue while testing on Exynos5420 with these patches [1].
[1] https://lkml.org/lkml/2013/8/1/38
>> Updating only the required fields in threshold register fixes this issue.
>
> With the current code there is indeed a time window during which threshold
> limit for hardware trip point is set to zero so the fix is correct.
>
--
Tushar Behera
prev parent reply other threads:[~2014-04-24 11:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 5:38 [PATCH] thermal: samsung: Only update available threshold limits Tushar Behera
2014-04-24 3:17 ` Tushar Behera
2014-04-24 6:18 ` Amit Kachhap
2014-05-09 11:47 ` Tushar Behera
2014-05-15 8:45 ` Zhang Rui
2014-04-24 10:48 ` Bartlomiej Zolnierkiewicz
2014-04-24 11:30 ` Tushar Behera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5358F5D4.1010506@linaro.org \
--to=tushar.behera@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=eduardo.valentin@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.