From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>,
Avi Kivity <avi.kivity@gmail.com>, Gleb Natapov <gleb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Dominik Dingel <dingel@linux.vnet.ibm.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] KVM: async_pf: use_mm/mm_users fixes
Date: Thu, 24 Apr 2014 16:27:49 +0200 [thread overview]
Message-ID: <53591F65.9010001@de.ibm.com> (raw)
In-Reply-To: <20140421132543.GA13594@redhat.com>
On 21/04/14 15:25, Oleg Nesterov wrote:
> Hello.
>
> Completely untested and I know nothing about kvm ;) Please review.
>
> But use_mm() really looks misleading, and the usage of mm_users looks
> "obviously wrong". I already sent this change while we were discussing
> vmacache, but it was ignored. Since then kvm_async_page_present_sync()
> was added into async_pf_execute() into async_pf_execute(), but it seems
> to me that use_mm() is still unnecessary.
>
> Oleg.
>
> virt/kvm/async_pf.c | 10 ++++------
> 1 files changed, 4 insertions(+), 6 deletions(-)
>
I gave both patches some testing on s390, seems fine. I think patch2 really
does fix a bug. So if Paolo, Marcelo, Gleb agree (maybe do a test on x86 for
async_pf) both patches are good to go. Given that somebody tests this on x86:
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
next prev parent reply other threads:[~2014-04-24 14:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 13:25 [PATCH 0/2] KVM: async_pf: use_mm/mm_users fixes Oleg Nesterov
2014-04-21 13:25 ` [PATCH 1/2] KVM: async_pf: kill the unnecessary use_mm/unuse_mm async_pf_execute() Oleg Nesterov
2014-04-22 20:15 ` Christian Borntraeger
2014-04-22 21:07 ` Christian Borntraeger
2014-04-23 19:32 ` Oleg Nesterov
2014-04-28 14:06 ` Andrea Arcangeli
2014-04-28 15:31 ` Paolo Bonzini
2014-04-21 13:26 ` [PATCH 2/2] KVM: async_pf: mm->mm_users can not pin apf->mm Oleg Nesterov
2014-04-22 20:24 ` Christian Borntraeger
2014-04-24 14:27 ` Christian Borntraeger [this message]
2014-04-24 14:55 ` [PATCH 0/2] KVM: async_pf: use_mm/mm_users fixes Oleg Nesterov
2014-04-28 11:06 ` Paolo Bonzini
2014-04-28 14:15 ` Andrea Arcangeli
2014-04-28 15:02 ` [PATCH 3/2] KVM: async_pf: change async_pf_execute() to use get_user_pages(tsk => NULL) Oleg Nesterov
2014-04-28 15:03 ` Oleg Nesterov
2014-04-28 15:27 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53591F65.9010001@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=avi.kivity@gmail.com \
--cc=dingel@linux.vnet.ibm.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.