From: Eric Sandeen <sandeen@sandeen.net>
To: Lukas Czerner <lczerner@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: Use _require_xfs_io_command() instead of helpers
Date: Thu, 24 Apr 2014 11:55:43 -0500 [thread overview]
Message-ID: <5359420F.3020406@sandeen.net> (raw)
In-Reply-To: <1398355303-29348-1-git-send-email-lczerner@redhat.com>
On 4/24/14, 11:01 AM, Lukas Czerner wrote:
> Number of helpers for checking xfs_io functionality is slowly growing.
> But it's as easy to simply use _require_xfs_io_command() directly and
> just specify the command we want to check. It will also avoid the need
> to create helper every time we need to check a new command in xfs_io.
>
> Remove all the helpers and use _require_xfs_io_command() in the tests.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
I like it.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-24 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 16:01 [PATCH] xfstests: Use _require_xfs_io_command() instead of helpers Lukas Czerner
2014-04-24 16:55 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5359420F.3020406@sandeen.net \
--to=sandeen@sandeen.net \
--cc=lczerner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.