From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH] ARM: dts: exynos4: clean up arm-pmu node Date: Thu, 24 Apr 2014 19:04:22 +0200 Message-ID: <53594416.4070601@samsung.com> References: <1397480584-16195-1-git-send-email-chanho61.park@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:9266 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758597AbaDXREa (ORCPT ); Thu, 24 Apr 2014 13:04:30 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4J003UGORFIUB0@mailout1.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Thu, 24 Apr 2014 18:04:27 +0100 (BST) In-reply-to: <1397480584-16195-1-git-send-email-chanho61.park@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Chanho Park , kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Chanwoo Choi Hi Chanho, On 14.04.2014 15:03, Chanho Park wrote: > This patch cleans a arm-pmu node up for exynos4. Only exynos4412 series > boards have four pmu interrupts. Rest of exynos4 boards, except 4412, have only > two pmu interrupts. Thus, we can define two interrupts in the > exynos4.dtsi and extends the interrupts only exynos4412.dtsi. > > Cc: Chanwoo Choi > Signed-off-by: Chanho Park > --- > arch/arm/boot/dts/exynos4.dtsi | 6 ++++++ > arch/arm/boot/dts/exynos4210.dtsi | 6 ------ > arch/arm/boot/dts/exynos4412.dtsi | 6 ++++++ > arch/arm/boot/dts/exynos4x12.dtsi | 6 ------ > 4 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index e541ecb..6de978c 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -105,6 +105,12 @@ > reg = <0x10440000 0x1000>; > }; > > + pmu { > + compatible = "arm,cortex-a9-pmu"; > + interrupt-parent = <&combiner>; > + interrupts = <2 2>, <3 2>; > + }; > + > sys_reg: syscon@10010000 { > compatible = "samsung,exynos4-sysreg", "syscon"; > reg = <0x10010000 0x400>; > diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi > index cacf614..4e7610f 100644 > --- a/arch/arm/boot/dts/exynos4210.dtsi > +++ b/arch/arm/boot/dts/exynos4210.dtsi > @@ -75,12 +75,6 @@ > #clock-cells = <1>; > }; > > - pmu { > - compatible = "arm,cortex-a9-pmu"; > - interrupt-parent = <&combiner>; > - interrupts = <2 2>, <3 2>; > - }; > - > pinctrl_0: pinctrl@11400000 { > compatible = "samsung,exynos4210-pinctrl"; > reg = <0x11400000 0x1000>; > diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi > index 15d3c0a..e6af870 100644 > --- a/arch/arm/boot/dts/exynos4412.dtsi > +++ b/arch/arm/boot/dts/exynos4412.dtsi > @@ -26,6 +26,12 @@ > samsung,combiner-nr = <20>; > }; > > + pmu { > + compatible = "arm,cortex-a9-pmu"; > + interrupt-parent = <&combiner>; I guess you could omit the two properties above and let them be inherited from exynos4.dtsi. Otherwise looks fine. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: t.figa@samsung.com (Tomasz Figa) Date: Thu, 24 Apr 2014 19:04:22 +0200 Subject: [PATCH] ARM: dts: exynos4: clean up arm-pmu node In-Reply-To: <1397480584-16195-1-git-send-email-chanho61.park@samsung.com> References: <1397480584-16195-1-git-send-email-chanho61.park@samsung.com> Message-ID: <53594416.4070601@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chanho, On 14.04.2014 15:03, Chanho Park wrote: > This patch cleans a arm-pmu node up for exynos4. Only exynos4412 series > boards have four pmu interrupts. Rest of exynos4 boards, except 4412, have only > two pmu interrupts. Thus, we can define two interrupts in the > exynos4.dtsi and extends the interrupts only exynos4412.dtsi. > > Cc: Chanwoo Choi > Signed-off-by: Chanho Park > --- > arch/arm/boot/dts/exynos4.dtsi | 6 ++++++ > arch/arm/boot/dts/exynos4210.dtsi | 6 ------ > arch/arm/boot/dts/exynos4412.dtsi | 6 ++++++ > arch/arm/boot/dts/exynos4x12.dtsi | 6 ------ > 4 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index e541ecb..6de978c 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -105,6 +105,12 @@ > reg = <0x10440000 0x1000>; > }; > > + pmu { > + compatible = "arm,cortex-a9-pmu"; > + interrupt-parent = <&combiner>; > + interrupts = <2 2>, <3 2>; > + }; > + > sys_reg: syscon at 10010000 { > compatible = "samsung,exynos4-sysreg", "syscon"; > reg = <0x10010000 0x400>; > diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi > index cacf614..4e7610f 100644 > --- a/arch/arm/boot/dts/exynos4210.dtsi > +++ b/arch/arm/boot/dts/exynos4210.dtsi > @@ -75,12 +75,6 @@ > #clock-cells = <1>; > }; > > - pmu { > - compatible = "arm,cortex-a9-pmu"; > - interrupt-parent = <&combiner>; > - interrupts = <2 2>, <3 2>; > - }; > - > pinctrl_0: pinctrl at 11400000 { > compatible = "samsung,exynos4210-pinctrl"; > reg = <0x11400000 0x1000>; > diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi > index 15d3c0a..e6af870 100644 > --- a/arch/arm/boot/dts/exynos4412.dtsi > +++ b/arch/arm/boot/dts/exynos4412.dtsi > @@ -26,6 +26,12 @@ > samsung,combiner-nr = <20>; > }; > > + pmu { > + compatible = "arm,cortex-a9-pmu"; > + interrupt-parent = <&combiner>; I guess you could omit the two properties above and let them be inherited from exynos4.dtsi. Otherwise looks fine. Best regards, Tomasz