From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>,
linux-can@vger.kernel.org
Cc: wg@grandegger.com
Subject: Re: [PATCH v1] can: c_can: Enable interrupts only when initialization has been completed
Date: Fri, 25 Apr 2014 00:07:04 +0200 [thread overview]
Message-ID: <53598B08.1090100@pengutronix.de> (raw)
In-Reply-To: <1396459685-8133-1-git-send-email-oleksandr.tyshchenko@globallogic.com>
[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]
On 04/02/2014 07:28 PM, Oleksandr Tyshchenko wrote:
> In current driver realization we enable interrupts twice from c_can_start().
> First time in c_can_start()->c_can_chip_config() during set operating mode.
> Second time in the end of c_can_start() after finish basic controller
> configuration.
>
> Enabling interrupts in first place (while initialization is ongoing)
> may cause to interrupts when the CAN chip is not completely initialized.
> Also if basic controller configuration failed with error,
> we will leave initialization sequence with interrupts enabled.
>
> We have to enable interrupts only when initialization has been completed.
> So, don't enable interrupts while initialization is ongoing.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>
Can you please rebase this to
git://gitorious.org/linux-can/linux-can.git
tags/linux-can-fixes-for-3.15-20140424
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
prev parent reply other threads:[~2014-04-24 22:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 17:28 [PATCH v1] can: c_can: Enable interrupts only when initialization has been completed Oleksandr Tyshchenko
2014-04-24 22:07 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53598B08.1090100@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=oleksandr.tyshchenko@globallogic.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.