All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <dborkman@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: ast@plumgrid.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/5] net: filter: misc/various cleanups
Date: Fri, 25 Apr 2014 09:52:14 +0200	[thread overview]
Message-ID: <535A142E.9060609@redhat.com> (raw)
In-Reply-To: <20140424.160050.2258325688773881218.davem@davemloft.net>

On 04/24/2014 10:00 PM, David Miller wrote:
> From: Daniel Borkmann <dborkman@redhat.com>
> Date: Thu, 24 Apr 2014 08:45:24 +0200
>
>> +	return __skb_get_poff((struct sk_buff *)(long) ctx);
>
> Please use "unsigned long" when casting pointers to/from integers.

I'll fix it up, thanks.

There's ongoing work to improve the documentation file to address
your concerns.

Thanks,

Daniel

  reply	other threads:[~2014-04-25  7:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24  6:45 [PATCH net-next v2 0/5] BPF updates Daniel Borkmann
2014-04-24  6:45 ` [PATCH net-next v2 1/5] net: filter: simplify label names from jump-table Daniel Borkmann
2014-04-24  6:45 ` [PATCH net-next v2 2/5] net: filter: misc/various cleanups Daniel Borkmann
2014-04-24 20:00   ` David Miller
2014-04-25  7:52     ` Daniel Borkmann [this message]
2014-04-24  6:45 ` [PATCH net-next v2 3/5] net: filter: get rid of sock_fprog_kern Daniel Borkmann
2014-04-24 20:02   ` David Miller
2014-04-25  7:58     ` Daniel Borkmann
2014-04-24  6:45 ` [PATCH net-next v2 4/5] net: filter: make register namings more comprehensible Daniel Borkmann
2014-04-24  6:45 ` [PATCH net-next v2 5/5] net: filter: optimize BPF migration for ARG1/CTX handling Daniel Borkmann
2014-04-24 15:43   ` Alexei Starovoitov
2014-04-24 20:04   ` David Miller
2014-04-26 18:06     ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535A142E.9060609@redhat.com \
    --to=dborkman@redhat.com \
    --cc=ast@plumgrid.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.