From: Jeff Liu <jeff.liu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH v2 10/10] xfs: isolate xfs_qm_quotacheck to its source file
Date: Fri, 25 Apr 2014 16:05:36 +0800 [thread overview]
Message-ID: <535A1750.20109@oracle.com> (raw)
In-Reply-To: <20140425065545.GE20871@infradead.org>
On 04/25 2014 14:55 PM, Christoph Hellwig wrote:
> On Fri, Apr 18, 2014 at 08:59:00AM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> Isolate xfs_qm_quotacheck() to xfs_qm.c as there is no other users of it.
>>
>> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
>
> Looks good, but the description is a bit confusing, we'd normallay say
> something like:
>
> "xfs: mark xfs_qm_quotacheck as static
>
> xfs_qm_quotacheck is not used outside of xfs_qm.c. Mark it static and
> move it around in the file to avoid a forward declaration."
Nice suggestion, thanks for your review.
Thanks,
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-25 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 0:59 [PATCH v2 10/10] xfs: isolate xfs_qm_quotacheck to its source file Jeff Liu
2014-04-25 6:55 ` Christoph Hellwig
2014-04-25 8:05 ` Jeff Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535A1750.20109@oracle.com \
--to=jeff.liu@oracle.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.