All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Raymond Yau <superquad.vortex2@gmail.com>,
	"Alexander E. Patrakov" <patrakov@gmail.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] Fix forward/rewind support in iec958 plugin
Date: Fri, 25 Apr 2014 10:09:37 +0200	[thread overview]
Message-ID: <535A1841.8070208@ladisch.de> (raw)
In-Reply-To: <CAN8cciadq+=36DcMufwDD=M5=0EAdnkUxPv8b9Ga5JHWqg1-Hg@mail.gmail.com>

Raymond Yau wrote:
>> When forwarding or rewinding, the frame counter was not updated. This
>> could result in corrupted channel status words or misplaced Z-type
>> preamble.
>
> Do you mean it is the responsibility for a52 and dca plugin to return the
> SAFE value returned by snd_pcm_rewindable and snd_pcm_forwardable since
> they enocde the audio and padding zeros and write to IEC958 ?

The a52/dca plugins create data to be transferred over S/PDIF, but this
does not imply they use the iec958 plugin.

The iec958 plugin is used for sound cards that do not have a hardware
IEC958 encoder.  This is very unlikely nowadays.


Regards,
Clemens

  parent reply	other threads:[~2014-04-25  8:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23 18:40 [PATCH] Fix forward/rewind support in iec958 plugin Alexander E. Patrakov
2014-04-24 11:19 ` David Henningsson
2014-04-24 14:40   ` [PATCH v2] " Alexander E. Patrakov
2014-04-24 23:02     ` Raymond Yau
2014-04-25  6:00       ` Alexander E. Patrakov
2014-04-25  8:09       ` Clemens Ladisch [this message]
2014-04-28 16:10     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535A1841.8070208@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=patrakov@gmail.com \
    --cc=superquad.vortex2@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.