[PATCHv2 0/4] Enable usbphy and hsotg for exynos4

[PATCHv2 0/4] Enable usbphy and hsotg for exynos4

[Chanho Park]

This patchset enables a exynos4 usbphy and hsotg DT node for exynos4. The usb
phy node uses generic exynos phy driver. The driver uses PMU syscon and SYSREG
syscon phandles.

Changes from v1: Applied Tomasz Figa's comments
 - Document PMU syscon compatibles for exynos4210/4x12
 - Use clock macro instead of raw clock number
 - Correct phy name to "usb2-phy"

Chanho Park (4):
  ARM: dts: exynos4: add PMU syscon node
  ARM: dts: exynos4: add exynos_usbphy node
  ARM: dts: exynos4: add hsotg device node
  ARM: dts: exynos4412-trats2: enable usb nodes

 .../devicetree/bindings/arm/samsung/pmu.txt        |  2 ++
 arch/arm/boot/dts/exynos4.dtsi                     | 26 ++++++++++++++++++++++
 arch/arm/boot/dts/exynos4412-trats2.dts            | 10 +++++++++
 arch/arm/boot/dts/exynos4x12.dtsi                  |  9 ++++++++
 4 files changed, 47 insertions(+)

-- 
1.8.3.2

[PATCHv2 1/4] ARM: dts: exynos4: add PMU syscon node

[Chanho Park]

This patch adds a PMU(Power Management Unit) syscon node. This
should be required for USB Phy syscon regmap I/F.

Cc: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
 Documentation/devicetree/bindings/arm/samsung/pmu.txt | 2 ++
 arch/arm/boot/dts/exynos4.dtsi                        | 5 +++++
 arch/arm/boot/dts/exynos4x12.dtsi                     | 4 ++++
 3 files changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
index f1f1552..e2797d1 100644
--- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
@@ -2,6 +2,8 @@ SAMSUNG Exynos SoC series PMU Registers
 
 Properties:
  - compatible : should contain two values. First value must be one from following list:
+		   - "samsung,exynos4210-pmu" - for Exynos4210 SoC,
+		   - "samsung,exynos4x12-pmu" - for Exynos4212/4412 SoC,
 		   - "samsung,exynos5250-pmu" - for Exynos5250 SoC,
 		   - "samsung,exynos5420-pmu" - for Exynos5420 SoC.
 		second value must be always "syscon".
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 2f8bcd0..264066f 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -110,6 +110,11 @@
 		reg = <0x10010000 0x400>;
 	};
 
+	pmu_system_controller: system-controller@10020000 {
+		compatible = "samsung,exynos4210-pmu", "syscon";
+		reg = <0x10020000 0x4000>;
+	};
+
 	dsi_0: dsi@11C80000 {
 		compatible = "samsung,exynos4210-mipi-dsi";
 		reg = <0x11C80000 0x10000>;
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index c4a9306..7f767f7 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -119,6 +119,10 @@
 		interrupts = <0 72 0>;
 	};
 
+	pmu_system_controller: system-controller@10020000 {
+		compatible = "samsung,exynos4x12-pmu", "syscon";
+	};
+
 	g2d@10800000 {
 		compatible = "samsung,exynos4212-g2d";
 		reg = <0x10800000 0x1000>;
-- 
1.8.3.2

Re: [PATCHv2 1/4] ARM: dts: exynos4: add PMU syscon node

[Tomasz Figa]

Hi Chanho,

On 25.04.2014 08:59, Chanho Park wrote:
> This patch adds a PMU(Power Management Unit) syscon node. This
> should be required for USB Phy syscon regmap I/F.
>
> Cc: Kamil Debski <k.debski@samsung.com>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> ---
>   Documentation/devicetree/bindings/arm/samsung/pmu.txt | 2 ++
>   arch/arm/boot/dts/exynos4.dtsi                        | 5 +++++
>   arch/arm/boot/dts/exynos4x12.dtsi                     | 4 ++++
>   3 files changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> index f1f1552..e2797d1 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> @@ -2,6 +2,8 @@ SAMSUNG Exynos SoC series PMU Registers
>
>   Properties:
>    - compatible : should contain two values. First value must be one from following list:
> +		   - "samsung,exynos4210-pmu" - for Exynos4210 SoC,
> +		   - "samsung,exynos4x12-pmu" - for Exynos4212/4412 SoC,

Actually there are differences between PMUs of 4212 and 4412 (mostly 
count of CPU-related registers), so they should have separate compatible 
strings. I have missed this in previous version of this patch, sorry.

Best regards,
Tomasz

[PATCHv2 2/4] ARM: dts: exynos4: add exynos_usbphy node

[Chanho Park]

This patch enables a exynos_usbphy node for exynos4 SoCs.
A exynos4x12 usb phy node is almost same with 4210's one
except compatible string and pmu syscon.

Cc: Tomasz Figa <t.figa@samsung.com>
Cc: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
 arch/arm/boot/dts/exynos4.dtsi    | 10 ++++++++++
 arch/arm/boot/dts/exynos4x12.dtsi |  5 +++++
 2 files changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 264066f..5f9b23b 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -278,6 +278,16 @@
 		status = "disabled";
 	};
 
+	exynos_usbphy: exynos-usbphy@125B0000 {
+		compatible = "samsung,exynos4210-usb2-phy";
+		reg = <0x125B0000 0x100>;
+		samsung,pmureg-phandle = <&pmu_system_controller>;
+		clocks = <&clock CLK_USB_DEVICE>, <&clock CLK_XUSBXTI>;
+		clock-names = "phy", "ref";
+		status = "disabled";
+		#phy-cells = <1>;
+	};
+
 	ehci@12580000 {
 		compatible = "samsung,exynos4210-ehci";
 		reg = <0x12580000 0x100>;
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index 7f767f7..6d9a21a 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -247,4 +247,9 @@
 		clock-names = "biu", "ciu";
 		status = "disabled";
 	};
+
+	exynos-usbphy@125B0000 {
+		compatible = "samsung,exynos4x12-usb2-phy";
+		samsung,sysreg-phandle = <&sys_reg>;
+	};
 };
-- 
1.8.3.2

Re: [PATCHv2 2/4] ARM: dts: exynos4: add exynos_usbphy node

[Sachin Kamat]

Hi Chanho,

On 25 April 2014 12:29, Chanho Park <chanho61.park@samsung.com> wrote:
> This patch enables a exynos_usbphy node for exynos4 SoCs.
> A exynos4x12 usb phy node is almost same with 4210's one
> except compatible string and pmu syscon.
>
> Cc: Tomasz Figa <t.figa@samsung.com>
> Cc: Kamil Debski <k.debski@samsung.com>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4.dtsi    | 10 ++++++++++
>  arch/arm/boot/dts/exynos4x12.dtsi |  5 +++++
>  2 files changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 264066f..5f9b23b 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -278,6 +278,16 @@
>                 status = "disabled";
>         };
>
> +       exynos_usbphy: exynos-usbphy@125B0000 {
> +               compatible = "samsung,exynos4210-usb2-phy";
> +               reg = <0x125B0000 0x100>;
> +               samsung,pmureg-phandle = <&pmu_system_controller>;
> +               clocks = <&clock CLK_USB_DEVICE>, <&clock CLK_XUSBXTI>;
> +               clock-names = "phy", "ref";
> +               status = "disabled";

For readability it is better if status line is the last entry of the node.

---
With warm regards,
Sachin

RE: [PATCHv2 2/4] ARM: dts: exynos4: add exynos_usbphy node

[Chanho Park]

Hi Sachin,

> -----Original Message-----
> From: Sachin Kamat [mailto:sachin.kamat@linaro.org]
> Sent: Tuesday, April 29, 2014 6:23 PM
> To: Chanho Park
> Cc: Kukjin Kim; linux-samsung-soc; Tomasz Figa; Kamil Debski;
> devicetree@vger.kernel.org
> Subject: Re: [PATCHv2 2/4] ARM: dts: exynos4: add exynos_usbphy node
> 
> Hi Chanho,
> 
> On 25 April 2014 12:29, Chanho Park <chanho61.park@samsung.com> wrote:
> > This patch enables a exynos_usbphy node for exynos4 SoCs.
> > A exynos4x12 usb phy node is almost same with 4210's one
> > except compatible string and pmu syscon.
> >
> > Cc: Tomasz Figa <t.figa@samsung.com>
> > Cc: Kamil Debski <k.debski@samsung.com>
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> > ---
> >  arch/arm/boot/dts/exynos4.dtsi    | 10 ++++++++++
> >  arch/arm/boot/dts/exynos4x12.dtsi |  5 +++++
> >  2 files changed, 15 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos4.dtsi
> b/arch/arm/boot/dts/exynos4.dtsi
> > index 264066f..5f9b23b 100644
> > --- a/arch/arm/boot/dts/exynos4.dtsi
> > +++ b/arch/arm/boot/dts/exynos4.dtsi
> > @@ -278,6 +278,16 @@
> >                 status = "disabled";
> >         };
> >
> > +       exynos_usbphy: exynos-usbphy@125B0000 {
> > +               compatible = "samsung,exynos4210-usb2-phy";
> > +               reg = <0x125B0000 0x100>;
> > +               samsung,pmureg-phandle = <&pmu_system_controller>;
> > +               clocks = <&clock CLK_USB_DEVICE>, <&clock CLK_XUSBXTI>;
> > +               clock-names = "phy", "ref";
> > +               status = "disabled";
> 
> For readability it is better if status line is the last entry of the
> node.

Yes. It could be more readable it is in the last line. I'll update it in next patch.
Thanks.

Best Regards,
Chanho Park

[PATCHv2 3/4] ARM: dts: exynos4: add hsotg device node

[Chanho Park]

This patch adds a hsotg node for exynos4 USB2.0 device controller.

Cc: Tomasz Figa <t.figa@samsung.com>
Cc: Kamil Debski <k.debski@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
 arch/arm/boot/dts/exynos4.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 5f9b23b..f8000dd 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -288,6 +288,17 @@
 		#phy-cells = <1>;
 	};
 
+	hsotg@12480000 {
+		compatible = "samsung,s3c6400-hsotg";
+		reg = <0x12480000 0x20000>;
+		interrupts = <0 71 0>;
+		clocks = <&clock CLK_USB_DEVICE>;
+		clock-names = "otg";
+		phys = <&exynos_usbphy 0>;
+		phy-names = "usb2-phy";
+		status = "disabled";
+	};
+
 	ehci@12580000 {
 		compatible = "samsung,exynos4210-ehci";
 		reg = <0x12580000 0x100>;
-- 
1.8.3.2

[PATCHv2 4/4] ARM: dts: exynos4412-trats2: enable usb nodes

[Chanho Park]

This patch enables exynos_usbphy and hsotg device nodes.

Cc: Tomasz Figa <t.figa@samsung.com>
Cc: Kamil Debski <k.debski@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
 arch/arm/boot/dts/exynos4412-trats2.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index 9583563..a16db6c 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -665,6 +665,16 @@
 		};
 	};
 
+	exynos-usbphy@125B0000 {
+		status = "okay";
+	};
+
+	hsotg@12480000 {
+		vusb_d-supply = <&ldo15_reg>;
+		vusb_a-supply = <&ldo12_reg>;
+		status = "okay";
+	};
+
 	thermistor-ap@0 {
 		compatible = "ntc,ncp15wb473";
 		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
-- 
1.8.3.2

Re: [PATCHv2 0/4] Enable usbphy and hsotg for exynos4

[Tomasz Figa]

Hi Chanho,

On 25.04.2014 08:59, Chanho Park wrote:
> This patchset enables a exynos4 usbphy and hsotg DT node for exynos4. The usb
> phy node uses generic exynos phy driver. The driver uses PMU syscon and SYSREG
> syscon phandles.
> 
> Changes from v1: Applied Tomasz Figa's comments
>  - Document PMU syscon compatibles for exynos4210/4x12
>  - Use clock macro instead of raw clock number
>  - Correct phy name to "usb2-phy"
> 
> Chanho Park (4):
>   ARM: dts: exynos4: add PMU syscon node
>   ARM: dts: exynos4: add exynos_usbphy node
>   ARM: dts: exynos4: add hsotg device node
>   ARM: dts: exynos4412-trats2: enable usb nodes
> 
>  .../devicetree/bindings/arm/samsung/pmu.txt        |  2 ++
>  arch/arm/boot/dts/exynos4.dtsi                     | 26 ++++++++++++++++++++++
>  arch/arm/boot/dts/exynos4412-trats2.dts            | 10 +++++++++
>  arch/arm/boot/dts/exynos4x12.dtsi                  |  9 ++++++++
>  4 files changed, 47 insertions(+)
> 

For the whole series:

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

--
Best regards,
Tomasz