From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:1599 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753093AbaDYKgg (ORCPT ); Fri, 25 Apr 2014 06:36:36 -0400 Message-ID: <535A3D6D.8020008@linux.intel.com> Date: Fri, 25 Apr 2014 13:48:13 +0300 From: Mathias Nyman MIME-Version: 1.0 To: Greg KH CC: linux-usb@vger.kernel.org, sarah.a.sharp@linux.intel.com, linux-kernel@vger.kernel.org, Alexander Gordeev , linux-pci@vger.kernel.org Subject: Re: [PATCH 2/5] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix() References: <1398169382-12097-1-git-send-email-mathias.nyman@linux.intel.com> <1398169382-12097-3-git-send-email-mathias.nyman@linux.intel.com> <20140424194926.GB12809@kroah.com> In-Reply-To: <20140424194926.GB12809@kroah.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-pci-owner@vger.kernel.org List-ID: On 04/24/2014 10:49 PM, Greg KH wrote: > On Tue, Apr 22, 2014 at 03:22:59PM +0300, Mathias Nyman wrote: >> From: Alexander Gordeev >> >> As result of deprecation of MSI-X/MSI enablement functions >> pci_enable_msix() and pci_enable_msi_block() all drivers >> using these two interfaces need to be updated to use the >> new pci_enable_msi_range() or pci_enable_msi_exact() >> and pci_enable_msix_range() or pci_enable_msix_exact() >> interfaces. >> >> Signed-off-by: Alexander Gordeev >> Cc: Sarah Sharp >> Cc: Greg Kroah-Hartman >> Cc: linux-usb@vger.kernel.org >> Cc: linux-pci@vger.kernel.org >> Signed-off-by: Mathias Nyman >> --- >> drivers/usb/host/xhci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c >> index 988ed5f..b0b8399 100644 >> --- a/drivers/usb/host/xhci.c >> +++ b/drivers/usb/host/xhci.c >> @@ -291,7 +291,7 @@ static int xhci_setup_msix(struct xhci_hcd *xhci) >> xhci->msix_entries[i].vector = 0; >> } >> >> - ret = pci_enable_msix(pdev, xhci->msix_entries, xhci->msix_count); >> + ret = pci_enable_msix_exact(pdev, xhci->msix_entries, xhci->msix_count); > > Why is this change needed for 3.15-final? > Can't remember why I thought this was needed for 3.15 Looks like other subsystems (like PCI) just queued similar MSI changes for 3.16. I'll move it to the patchseries for usb-next -Mathias