From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 1/8] tools: libxl: use uint64_t not unsigned long long for addresses Date: Fri, 25 Apr 2014 12:42:28 +0100 Message-ID: <535A4A24.10709@linaro.org> References: <1398424945.18537.424.camel@kazak.uk.xensource.com> <1398424967-9306-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1398424967-9306-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: ian.jackson@eu.citrix.com, tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 25/04/14 12:22, Ian Campbell wrote: > Signed-off-by: Ian Campbell Acked-by: Julien Grall > --- > v2: New patch > --- > tools/libxl/libxl_arm.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c > index 4f0f0e2..215ef9e 100644 > --- a/tools/libxl/libxl_arm.c > +++ b/tools/libxl/libxl_arm.c > @@ -256,11 +256,10 @@ static int make_psci_node(libxl__gc *gc, void *fdt) > } > > static int make_memory_node(libxl__gc *gc, void *fdt, > - unsigned long long base, > - unsigned long long size) > + uint64_t base, uint64_t size) > { > int res; > - const char *name = GCSPRINTF("memory@%08llx", base); > + const char *name = GCSPRINTF("memory@%"PRIx64, base); > > res = fdt_begin_node(fdt, name); > if (res) return res; > @@ -269,7 +268,7 @@ static int make_memory_node(libxl__gc *gc, void *fdt, > if (res) return res; > > res = fdt_property_regs(gc, fdt, ROOT_ADDRESS_CELLS, ROOT_SIZE_CELLS, > - 1, (uint64_t)base, (uint64_t)size); > + 1, base, size); > if (res) return res; > > res = fdt_end_node(fdt); > @@ -279,13 +278,11 @@ static int make_memory_node(libxl__gc *gc, void *fdt, > } > > static int make_intc_node(libxl__gc *gc, void *fdt, > - unsigned long long gicd_base, > - unsigned long long gicd_size, > - unsigned long long gicc_base, > - unsigned long long gicc_size) > + uint64_t gicd_base, uint64_t gicd_size, > + uint64_t gicc_base, uint64_t gicc_size) > { > int res; > - const char *name = GCSPRINTF("interrupt-controller@%08llx", gicd_base); > + const char *name = GCSPRINTF("interrupt-controller@%"PRIx64, gicd_base); > > res = fdt_begin_node(fdt, name); > if (res) return res; > @@ -307,8 +304,8 @@ static int make_intc_node(libxl__gc *gc, void *fdt, > > res = fdt_property_regs(gc, fdt, ROOT_ADDRESS_CELLS, ROOT_SIZE_CELLS, > 2, > - (uint64_t)gicd_base, (uint64_t)gicd_size, > - (uint64_t)gicc_base, (uint64_t)gicc_size); > + gicd_base, gicd_size, > + gicc_base, gicc_size); > if (res) return res; > > res = fdt_property_cell(fdt, "linux,phandle", PHANDLE_GIC); > -- Julien Grall