From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 3/8] tools: arm: move magic pfns out of guest RAM region Date: Fri, 25 Apr 2014 13:09:36 +0100 Message-ID: <535A5080.3020608@linaro.org> References: <1398424945.18537.424.camel@kazak.uk.xensource.com> <1398424967-9306-3-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1398424967-9306-3-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: ian.jackson@eu.citrix.com, tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 25/04/14 12:22, Ian Campbell wrote: > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > index dd53c94..a94d16b 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -375,6 +375,8 @@ typedef uint64_t xen_callback_t; > #define GUEST_GNTTAB_BASE 0xb0000000ULL > #define GUEST_GNTTAB_SIZE 0x00020000ULL > > +#define GUEST_MAGIC_BASE 0xc0000000ULL > + I'm wondering if we need to move NR_MAGIC_PAGES or add a comment in arch-arm.h if someone wants to bump the number page magic page. Or perhaps a BUG_ON in libxc to check at compilation time the hole is large enought to hold all special pages. -- Julien Grall