From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 5/8] tools: arm: prepare for multiple banks of guest RAM Date: Fri, 25 Apr 2014 13:34:18 +0100 Message-ID: <535A564A.7060205@linaro.org> References: <1398424945.18537.424.camel@kazak.uk.xensource.com> <1398424967-9306-5-git-send-email-ian.campbell@citrix.com> <535A52D7.3050801@linaro.org> <1398428599.18537.450.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1398428599.18537.450.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 25/04/14 13:23, Ian Campbell wrote: > On Fri, 2014-04-25 at 13:19 +0100, Julien Grall wrote: >> Hi Ian, >> >> On 25/04/14 12:22, Ian Campbell wrote: >>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h >>> index 4149d6f..c4f4990 100644 >>> --- a/xen/include/public/arch-arm.h >>> +++ b/xen/include/public/arch-arm.h >>> @@ -374,8 +374,12 @@ typedef uint64_t xen_callback_t; >>> >>> #define GUEST_MAGIC_BASE 0x39000000ULL >>> >>> -#define GUEST_RAM_BASE 0x40000000ULL /* 3GB of RAM @ 1GB */ >>> -#define GUEST_RAM_SIZE 0xc0000000ULL >>> +#define GUEST_RAM0_BASE 0x40000000ULL /* 3GB of RAM @ 1GB */ >>> +#define GUEST_RAM0_SIZE 0xc0000000ULL >>> + >>> +#define GUEST_RAM_BASE GUEST_RAM0_BASE /* Lowest RAM address */ >> >> Is it necessary to define GUEST_RAM_BASE? I don't see any usage of this >> define in this patch series. > > $ git grep GUEST_RAM_BASE > tools/libxl/libxl_dom.c:#ifdef GUEST_RAM_BASE > tools/libxl/libxl_dom.c: if ( (ret = xc_dom_rambase_init(dom, GUEST_RAM_BASE I forgot this one. Sorry. Acked-by: Julien Grall -- Julien Grall