From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stratos Karafotis Subject: Re: [PATCH v4 2/8] cpufreq: Use cpufreq_for_each_* macros for frequency table iteration Date: Fri, 25 Apr 2014 18:11:20 +0300 Message-ID: <535A7B18.9070505@semaphore.gr> References: <534DB1EB.1080401@semaphore.gr> <5355A327.3020308@semaphore.gr> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="utf-8" To: Prabhakar Lad Cc: "Rafael J. Wysocki" , Viresh Kumar , Kukjin Kim , linux-pm@vger.kernel.org, LKML , "cpufreq@vger.kernel.org" , linux-samsung-soc , Sudeep Holla , Olof Johansson , linuxppc-dev@lists.ozlabs.org, "linux-arm-kernel@lists.infradead.org" Hi Prabhakar, On 25/04/2014 03:31 =CE=BC=CE=BC, Prabhakar Lad wrote: > Hi Stratos, >=20 > Thanks for the patch. >=20 > On Tue, Apr 22, 2014 at 4:30 AM, Stratos Karafotis > wrote: >> The cpufreq core now supports the cpufreq_for_each_entry and >> cpufreq_for_each_valid_entry macros helpers for iteration over the >> cpufreq_frequency_table, so use them. >> >> It should have no functional changes. >> > This patch produces following build warning, >=20 > drivers/cpufreq/freq_table.c: In function 'cpufreq_frequency_table_cp= uinfo': > drivers/cpufreq/freq_table.c:36:3: warning: format '%lu' expects > argument of type 'long unsigned int', but argument 2 has type 'int' > [-Wformat=3D] > pr_debug("table entry %lu: %u kHz\n", pos - table, freq); Thanks for this finding. I will fix it and resend the patch. Stratos Karafotis From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sema.semaphore.gr (unknown [78.46.194.137]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 89FFD140129 for ; Sat, 26 Apr 2014 01:11:28 +1000 (EST) Message-ID: <535A7B18.9070505@semaphore.gr> Date: Fri, 25 Apr 2014 18:11:20 +0300 From: Stratos Karafotis MIME-Version: 1.0 To: Prabhakar Lad Subject: Re: [PATCH v4 2/8] cpufreq: Use cpufreq_for_each_* macros for frequency table iteration References: <534DB1EB.1080401@semaphore.gr> <5355A327.3020308@semaphore.gr> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Cc: Kukjin Kim , linux-pm@vger.kernel.org, Viresh Kumar , "Rafael J. Wysocki" , LKML , "cpufreq@vger.kernel.org" , linux-samsung-soc , Sudeep Holla , Olof Johansson , linuxppc-dev@lists.ozlabs.org, "linux-arm-kernel@lists.infradead.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Prabhakar, On 25/04/2014 03:31 μμ, Prabhakar Lad wrote: > Hi Stratos, > > Thanks for the patch. > > On Tue, Apr 22, 2014 at 4:30 AM, Stratos Karafotis > wrote: >> The cpufreq core now supports the cpufreq_for_each_entry and >> cpufreq_for_each_valid_entry macros helpers for iteration over the >> cpufreq_frequency_table, so use them. >> >> It should have no functional changes. >> > This patch produces following build warning, > > drivers/cpufreq/freq_table.c: In function 'cpufreq_frequency_table_cpuinfo': > drivers/cpufreq/freq_table.c:36:3: warning: format '%lu' expects > argument of type 'long unsigned int', but argument 2 has type 'int' > [-Wformat=] > pr_debug("table entry %lu: %u kHz\n", pos - table, freq); Thanks for this finding. I will fix it and resend the patch. Stratos Karafotis From mboxrd@z Thu Jan 1 00:00:00 1970 From: stratosk@semaphore.gr (Stratos Karafotis) Date: Fri, 25 Apr 2014 18:11:20 +0300 Subject: [PATCH v4 2/8] cpufreq: Use cpufreq_for_each_* macros for frequency table iteration In-Reply-To: References: <534DB1EB.1080401@semaphore.gr> <5355A327.3020308@semaphore.gr> Message-ID: <535A7B18.9070505@semaphore.gr> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Prabhakar, On 25/04/2014 03:31 ??, Prabhakar Lad wrote: > Hi Stratos, > > Thanks for the patch. > > On Tue, Apr 22, 2014 at 4:30 AM, Stratos Karafotis > wrote: >> The cpufreq core now supports the cpufreq_for_each_entry and >> cpufreq_for_each_valid_entry macros helpers for iteration over the >> cpufreq_frequency_table, so use them. >> >> It should have no functional changes. >> > This patch produces following build warning, > > drivers/cpufreq/freq_table.c: In function 'cpufreq_frequency_table_cpuinfo': > drivers/cpufreq/freq_table.c:36:3: warning: format '%lu' expects > argument of type 'long unsigned int', but argument 2 has type 'int' > [-Wformat=] > pr_debug("table entry %lu: %u kHz\n", pos - table, freq); Thanks for this finding. I will fix it and resend the patch. Stratos Karafotis