From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] xen-acpi-processor: Don't display errors when we get -ENOSYS Date: Fri, 25 Apr 2014 16:19:15 +0100 Message-ID: <535A7CF3.706@citrix.com> References: <1398438655-25665-1-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WdhuU-0007C6-BE for xen-devel@lists.xenproject.org; Fri, 25 Apr 2014 15:19:30 +0000 In-Reply-To: <1398438655-25665-1-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, david.vrabel@citrix.com List-Id: xen-devel@lists.xenproject.org On 25/04/14 16:10, Konrad Rzeszutek Wilk wrote: > which is a perfectly legal error. This can be triggered if the > user has booted Xen with the no-cpuidle parameter. > > Reported-by-and-Tested-by: Don Slutz > Signed-off-by: Konrad Rzeszutek Wilk > --- It would be more appropriate for Xen to return -ENODEV if it understands the ACPI hypercalls, but can't do anything with them. That cat is however out of the bag. ~Andrew > drivers/xen/xen-acpi-processor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c > index 82358d1..59fc190 100644 > --- a/drivers/xen/xen-acpi-processor.c > +++ b/drivers/xen/xen-acpi-processor.c > @@ -127,7 +127,7 @@ static int push_cxx_to_hypervisor(struct acpi_processor *_pr) > pr_debug(" C%d: %s %d uS\n", > cx->type, cx->desc, (u32)cx->latency); > } > - } else if (ret != -EINVAL) > + } else if ((ret != -EINVAL) && (ret != -ENOSYS)) > /* EINVAL means the ACPI ID is incorrect - meaning the ACPI > * table is referencing a non-existing CPU - which can happen > * with broken ACPI tables. */ > @@ -259,7 +259,7 @@ static int push_pxx_to_hypervisor(struct acpi_processor *_pr) > (u32) perf->states[i].power, > (u32) perf->states[i].transition_latency); > } > - } else if (ret != -EINVAL) > + } else if ((ret != -EINVAL) && (ret != -ENOSYS)) > /* EINVAL means the ACPI ID is incorrect - meaning the ACPI > * table is referencing a non-existing CPU - which can happen > * with broken ACPI tables. */