From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [Patch net] sched, cls: check if we could overwrite actions when changing a filter Date: Fri, 25 Apr 2014 11:48:26 -0400 Message-ID: <535A83CA.4030201@mojatatu.com> References: <1397605563-29756-1-git-send-email-xiyou.wangcong@gmail.com> <534E77D0.8000307@mojatatu.com> <534FBFF0.3020606@mojatatu.com> <53513619.5060202@mojatatu.com> <535259C3.10404@mojatatu.com> <5357A453.6030901@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Linux Kernel Network Developers , "David S. Miller" , Cong Wang To: Cong Wang Return-path: Received: from mail-ie0-f179.google.com ([209.85.223.179]:64912 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbaDYPsu (ORCPT ); Fri, 25 Apr 2014 11:48:50 -0400 Received: by mail-ie0-f179.google.com with SMTP id lx4so3846045iec.24 for ; Fri, 25 Apr 2014 08:48:50 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 04/24/14 17:12, Cong Wang wrote: > On Wed, Apr 23, 2014 at 4:30 AM, Jamal Hadi Salim wrote: >> >> I dont see what you are seeing. However, some quick tests will prove it. >> Example go from 1->3 actions and backwards 3->1 actions. >> I.e create a policy with (handwave) 3 actions and replace it with >> another that has only one action. Do this while you are sending a >> ping exercising this policy. >> I can see how yours with 1->0 and 0->1 will work. > > See below (with this patch applied): > Ok, thanks Cong. Since you are using this in your system already, I am assuming it is tested with running traffic at the same time. Please resubmit the patch with my signed off as well.. cheers, jamal