From: "Svenning Sørensen" <sss@secomea.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: guard against coalescing packets from buggy network drivers
Date: Fri, 25 Apr 2014 18:01:55 +0200 [thread overview]
Message-ID: <535A86F3.5010602@secomea.com> (raw)
In-Reply-To: <1398440595.29914.77.camel@edumazet-glaptop2.roam.corp.google.com>
On 25-04-2014 17:43, Eric Dumazet wrote:
>
> If you want a debugging patch, this should happen way before TCP stack
> or even IP stack.
>
> Say you want to use this buggy driver on a router, this code path will
> never bit hit.
>
You are right, of course, there are more effective ways to catch buggy
drivers.
But they will probably also be much more expensive.
This one is very cheap, being in a relatively cold path, especially
compared to the memcpy in the same path.
Svenning
next prev parent reply other threads:[~2014-04-25 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 15:02 [PATCH] net: guard against coalescing packets from buggy network drivers Svenning Sørensen
2014-04-25 15:43 ` Eric Dumazet
2014-04-25 16:01 ` Svenning Sørensen [this message]
2014-04-25 16:49 ` Eric Dumazet
2014-04-25 19:32 ` Svenning Sørensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535A86F3.5010602@secomea.com \
--to=sss@secomea.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.