From: Randy Dunlap <rdunlap@infradead.org>
To: Alexander Shiyan <shc_work@mail.ru>,
Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jon Ringle <jringle@gridpoint.com>,
jon@ringle.org
Subject: Re: [PATCH 1/2] serial: sc16is7xx: depend on I2C
Date: Fri, 25 Apr 2014 13:42:17 -0700 [thread overview]
Message-ID: <535AC8A9.9030303@infradead.org> (raw)
In-Reply-To: <1398458399.164274248@f343.i.mail.ru>
On 04/25/14 13:39, Alexander Shiyan wrote:
> Fri, 25 Apr 2014 13:35:28 -0700 от Greg KH <gregkh@linuxfoundation.org>:
>> On Sat, Apr 26, 2014 at 12:26:16AM +0400, Alexander Shiyan wrote:
>>> Fri, 25 Apr 2014 13:23:15 -0700 от Greg KH <gregkh@linuxfoundation.org>:
>>>> On Fri, Apr 25, 2014 at 03:53:09PM -0400, jon@ringle.org wrote:
>>>>> From: Jon Ringle <jringle@gridpoint.com>
>>>>>
>>>>> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
>>>>> ---
>>>>> drivers/tty/serial/Kconfig | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
>>>>> index c3e2b32..64c5659 100644
>>>>> --- a/drivers/tty/serial/Kconfig
>>>>> +++ b/drivers/tty/serial/Kconfig
>>>>> @@ -1180,6 +1180,7 @@ config SERIAL_SCCNXP_CONSOLE
>>>>>
>>>>> config SERIAL_SC16IS7XX
>>>>> tristate "SC16IS7xx serial support"
>>>>> + depends on I2C
>>>>> select SERIAL_CORE
>>>>> select REGMAP_I2C if I2C
>>>>> help
>>>>> --
>>>>> 1.8.5.4
>>>>
>>>> Better, but I still have the build warnings :(
>>>
>>> I hope not same as before?
>>
>> Exactly the same.
>
> Hmm...
>
> In the source:
> #ifdef CONFIG_REGMAP_I2C
> Should be of course #ifdef CONFIG_I2C
> But this should not provide such warnings...
Can I see the warnings and .config file that causes them?
--
~Randy
prev parent reply other threads:[~2014-04-25 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 19:53 [PATCH 1/2] serial: sc16is7xx: depend on I2C jon
2014-04-25 19:53 ` [PATCH 2/2] serial: sc16is7xx: fix implicit decl of func copy_{to,from}_user jon
2014-04-25 20:23 ` [PATCH 1/2] serial: sc16is7xx: depend on I2C Greg KH
2014-04-25 20:26 ` Alexander Shiyan
2014-04-25 20:26 ` Alexander Shiyan
2014-04-25 20:35 ` Greg KH
2014-04-25 20:35 ` Greg KH
2014-04-25 20:39 ` Alexander Shiyan
2014-04-25 20:39 ` Alexander Shiyan
2014-04-25 20:42 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535AC8A9.9030303@infradead.org \
--to=rdunlap@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jon@ringle.org \
--cc=jringle@gridpoint.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.