From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [optional PATCH v3 01/11] hvm/hpet: Add manual unit
 test code.
Date: Fri, 25 Apr 2014 17:26:08 -0400
Message-ID: <535AD2F0.8000005@terremark.com>
References: <1397756585-27091-1-git-send-email-dslutz@verizon.com>	<1397756585-27091-2-git-send-email-dslutz@verizon.com>
	<5357ED43020000780000B9C9@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5357ED43020000780000B9C9@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Don Slutz <dslutz@verizon.com>
Cc: Keir Fraser <keir@xen.org>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 04/23/14 10:41, Jan Beulich wrote:
>>>> On 17.04.14 at 19:42, <dslutz@verizon.com> wrote:
>> +hpet.h: $(XEN_ROOT)/xen/include/asm-x86/hpet.h
>> +	cp $(XEN_ROOT)/xen/include/asm-x86/hpet.h .
>> +
>> +hpet.c: $(XEN_ROOT)/xen/arch/x86/hvm/hpet.c
>> +	sed -e "/#include/d" -e "1i#include \"emul.h\"\n" <$(XEN_ROOT)/xen/arch/x86/hvm/hpet.c >hpet.c
> Just as a general remark (I'm not myself intending to review or commit
> this patch): You should try to use shortcuts when possible, i.e. $< and
> $@ in both above rules.

Ok
    -Don Slutz

> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel