Re: [PATCHv2 1/4] ARM: dts: exynos4: add PMU syscon node

[Tomasz Figa <tomasz.figa@gmail.com>]

Hi Chanho,

On 25.04.2014 08:59, Chanho Park wrote:
> This patch adds a PMU(Power Management Unit) syscon node. This
> should be required for USB Phy syscon regmap I/F.
>
> Cc: Kamil Debski <k.debski@samsung.com>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> ---
>   Documentation/devicetree/bindings/arm/samsung/pmu.txt | 2 ++
>   arch/arm/boot/dts/exynos4.dtsi                        | 5 +++++
>   arch/arm/boot/dts/exynos4x12.dtsi                     | 4 ++++
>   3 files changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> index f1f1552..e2797d1 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> @@ -2,6 +2,8 @@ SAMSUNG Exynos SoC series PMU Registers
>
>   Properties:
>    - compatible : should contain two values. First value must be one from following list:
> +		   - "samsung,exynos4210-pmu" - for Exynos4210 SoC,
> +		   - "samsung,exynos4x12-pmu" - for Exynos4212/4412 SoC,

Actually there are differences between PMUs of 4212 and 4412 (mostly 
count of CPU-related registers), so they should have separate compatible 
strings. I have missed this in previous version of this patch, sorry.

Best regards,
Tomasz