From: Ian Abbott <abbotti@mev.co.uk>
To: Christian Engelmayer <cengelma@gmx.at>, <devel@driverdev.osuosl.org>
Cc: <hsweeten@visionengravers.com>, <gregkh@linuxfoundation.org>,
<chase.southwood@yahoo.com>, <unixed@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: comedi: remove duplicate pointer assignments in attach functions
Date: Sat, 26 Apr 2014 16:56:52 +0100 [thread overview]
Message-ID: <535BD744.5030406@mev.co.uk> (raw)
In-Reply-To: <20140426160429.4883f678@spike>
On 26/04/14 15:04, Christian Engelmayer wrote:
> Some board pointer are assigned twice via comedi_board() in the comedi low
> level driver attach functions. Remove the duplicate assignment from the
> variable definition where the pointer is not used anyway until assigned later
> in the function when dev->board_ptr, that comedi_board() relies on, is setup
> correctly.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
> Compile tested and applies against v3.15-rc2 as well as branch staging-next
> of tree git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
Looks good!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2014-04-26 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 14:04 [PATCH] staging: comedi: remove duplicate pointer assignments in attach functions Christian Engelmayer
2014-04-26 15:56 ` Ian Abbott [this message]
2014-04-28 22:36 ` Hartley Sweeten
2014-04-29 18:59 ` Christian Engelmayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535BD744.5030406@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=cengelma@gmx.at \
--cc=chase.southwood@yahoo.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=unixed@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.