From: Michael Tokarev <mjt@tls.msk.ru>
To: Kirill Batuzov <batuzovk@ispras.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH trivial] init_paths: fix minor memory leak
Date: Sun, 27 Apr 2014 13:15:39 +0400 [thread overview]
Message-ID: <535CCABB.1060500@msgid.tls.msk.ru> (raw)
In-Reply-To: <1397138878-11770-1-git-send-email-batuzovk@ispras.ru>
10.04.2014 18:07, Kirill Batuzov wrote:
> Fields "name" (created with strdup in new_entry) and "pathname"
> (created with g_strdup_printf in new_entry) of pathelem struct should
> be freed before the whole struct is.
Applied to -trivial, thanks!
The fun thing here is that the code _looks_ correct. I think
it might be better to create proper API for destroying path
elements - new_entry() and its destroying counterpart, free_entry().
/mjt
prev parent reply other threads:[~2014-04-27 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 14:07 [Qemu-trivial] [PATCH trivial] init_paths: fix minor memory leak Kirill Batuzov
2014-04-10 14:07 ` [Qemu-devel] " Kirill Batuzov
2014-04-27 9:15 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535CCABB.1060500@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=batuzovk@ispras.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.