All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Baojun Wang <wangbj@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, eblake@redhat.com
Subject: Re: [Qemu-trivial] [PATCH V5 1/1] qmp: add pmemload command
Date: Sun, 27 Apr 2014 13:18:17 +0400	[thread overview]
Message-ID: <535CCB59.8020606@msgid.tls.msk.ru> (raw)
In-Reply-To: <1397065744-9561-1-git-send-email-wangbj@gmail.com>

09.04.2014 21:49, Baojun Wang wrote:
> I found this could be useful to have qemu-softmmu as a cross debugger (launch
> with -s -S command line option), then if we can have a command to load guest
> physical memory, we can use cross gdb to do some target debug which gdb cannot
> do directly.
> 
> Many thanks to Eric Blake for review the patch and suggestions.

Okay, that looks sane, but can you explain please, why did you address
qemu-trivial@?  The change definitely is not "trivial", as it introduces
a new qmp command which becomes a part of public interface.  Even if
the implementation may look trivial, the interface change should not be
done using -trivial tree.

Thanks,

/mjt


  reply	other threads:[~2014-04-27  9:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08 19:30 [Qemu-trivial] [PATCH V3 1/1] Add pmemsave command for both monitor and qmp, which could be useful to have qemu-softmmu as a cross debugger to load guest physical memory Baojun Wang
2014-04-08 19:30 ` [Qemu-devel] " Baojun Wang
2014-04-08 19:42 ` [Qemu-trivial] " Eric Blake
2014-04-08 19:42   ` [Qemu-devel] " Eric Blake
2014-04-08 23:29   ` [Qemu-trivial] " Baojun Wang
2014-04-08 23:29     ` [Qemu-devel] " Baojun Wang
2014-04-09 16:54     ` [Qemu-trivial] [PATCH V4 1/1] qmp: add pmemload command Baojun Wang
2014-04-09 16:54       ` [Qemu-devel] " Baojun Wang
2014-04-09 17:02       ` [Qemu-trivial] " Eric Blake
2014-04-09 17:02         ` [Qemu-devel] " Eric Blake
2014-04-09 17:49         ` [Qemu-trivial] [PATCH V5 " Baojun Wang
2014-04-09 17:49           ` [Qemu-devel] " Baojun Wang
2014-04-27  9:18           ` Michael Tokarev [this message]
2014-04-28  6:30             ` [Qemu-trivial] " Markus Armbruster
2014-04-30 18:00             ` [Qemu-trivial] " Baojun Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535CCB59.8020606@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=wangbj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.