From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WeMHu-0001Ae-1i for mharc-qemu-trivial@gnu.org; Sun, 27 Apr 2014 06:26:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WeMHn-00012A-Ah for qemu-trivial@nongnu.org; Sun, 27 Apr 2014 06:26:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WeMHi-0008Hf-BU for qemu-trivial@nongnu.org; Sun, 27 Apr 2014 06:26:15 -0400 Received: from v220110690675601.yourvserver.net ([37.221.199.173]:47285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WeMHO-00082T-4K; Sun, 27 Apr 2014 06:25:50 -0400 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id 0C81511822B5; Sun, 27 Apr 2014 12:25:48 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LtJ9bmkn38br; Sun, 27 Apr 2014 12:25:46 +0200 (CEST) Received: from [192.168.178.35] (p54ADB721.dip0.t-ipconnect.de [84.173.183.33]) by v220110690675601.yourvserver.net (Postfix) with ESMTPSA id AD8BE11822B4; Sun, 27 Apr 2014 12:25:45 +0200 (CEST) Message-ID: <535CDB28.5090607@weilnetz.de> Date: Sun, 27 Apr 2014 12:25:44 +0200 From: Stefan Weil User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Michael Tokarev , qemu-trivial@nongnu.org References: <1397822131-24372-1-git-send-email-sw@weilnetz.de> <535CCFC7.1040605@msgid.tls.msk.ru> In-Reply-To: <535CCFC7.1040605@msgid.tls.msk.ru> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 37.221.199.173 Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org Subject: Re: [Qemu-trivial] [PATCH] po/Makefile: Fix source path for in-tree builds X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Apr 2014 10:26:20 -0000 Am 27.04.2014 11:37, schrieb Michael Tokarev: > > How about moving it below inclusion of config-host.mak and using something like > > SRC_PATH ?= $(realpath ..) > > ? I dunno how gnu'ish this construct is... :) > > > However, I think I've a better fix for this: > > Author: Michael Tokarev > Date: Sun Apr 27 13:32:07 2014 +0400 > > po/Makefile: fix $SRC_PATH reference > > The rule for messages.po appears to be slightly wrong. > Move the `cd' command within parens. > > Signed-off-by: Michael Tokarev > Cc: Stefan Weil > Signed-off-by: Michael Tokarev > > diff --git a/po/Makefile b/po/Makefile > index 705166e..669f865 100644 > --- a/po/Makefile > +++ b/po/Makefile > @@ -37,8 +37,8 @@ install: $(OBJS) > $(call quiet-command, msgfmt -o $@ $<, " GEN $@") > > $(PO_PATH)/messages.po: $(SRC_PATH)/ui/gtk.c > - $(call quiet-command, cd $(SRC_PATH) && \ > - (xgettext -o - --from-code=UTF-8 --foreign-user \ > + $(call quiet-command, ( cd $(SRC_PATH) && \ > + xgettext -o - --from-code=UTF-8 --foreign-user \ > --package-name=QEMU --package-version=$(VERSION) \ > --msgid-bugs-address=qemu-devel@nongnu.org -k_ -C ui/gtk.c | \ > sed -e s/CHARSET/UTF-8/) >$@, " GEN $@") > > > Note the already existing parens () -- it looks like this is in order to > run commands within a subshell (with its own current directory) but still > have correct output redirection. > > If you don't have objections, I'll apply my version (it also fixes the issue). > > Thanks, > > /mjt > > Thanks, > > /mjt > Tested-by: Stefan Weil Cheers, Stefan