From: Paolo Bonzini <pbonzini@redhat.com>
To: "Hani Benhabiles" <kroosec@gmail.com>,
"Andreas Färber" <afaerber@suse.de>
Cc: qemu-trivial@nongnu.org, imammedo@redhat.com,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] qmp: Remove unused variable.
Date: Mon, 28 Apr 2014 10:38:27 +0200 [thread overview]
Message-ID: <535E1383.1090700@redhat.com> (raw)
In-Reply-To: <20140426004616.GA3514@Inspiron-3521>
Il 26/04/2014 02:46, Hani Benhabiles ha scritto:
>> if (ambiguous) {
>> > error_setg(errp, "Path '%s' is ambiguous.", path);
>> > } else {
>> > error_set(errp, QERR_DEVICE_NOT_FOUND, path);
>> > }
>> >
> Probably, you meant something like this:
>
> if (ambiguous) {
> error_set(errp, QERR_AMBIGUOUS_PATH, path);
> } else if (!obj) {
> error_set(errp, QERR_DEVICE_NOT_FOUND, path);
> }
>
>
No, error_set is being phased out. New errors typically use error_setg
instead.
Paolo
next prev parent reply other threads:[~2014-04-28 8:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 21:44 [Qemu-trivial] [PATCH] qmp: Remove unused variable Hani Benhabiles
2014-04-24 15:19 ` Michael Tokarev
2014-04-25 15:40 ` Luiz Capitulino
2014-04-25 15:51 ` Andreas Färber
2014-04-26 0:46 ` Hani Benhabiles
2014-04-28 8:38 ` Paolo Bonzini [this message]
2014-04-28 8:37 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535E1383.1090700@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=kroosec@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.