From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3 2/9] x86: move common_interrupt to entry.S
Date: Mon, 28 Apr 2014 10:49:56 +0100
Message-ID: <535E2444.1020701@citrix.com>
References: <1398654879-5934-1-git-send-email-feng.wu@intel.com>
	<535E1EA2.7070005@citrix.com>
	<535E400B020000780000CC6E@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <535E400B020000780000CC6E@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, Feng Wu <feng.wu@intel.com>, ian.campbell@citrix.com, eddie.dong@intel.com, xen-devel@lists.xen.org, jun.nakajima@intel.com
List-Id: xen-devel@lists.xenproject.org

On 28/04/14 10:48, Jan Beulich wrote:
>>>> On 28.04.14 at 11:25, <andrew.cooper3@citrix.com> wrote:
>> On 28/04/14 04:14, Feng Wu wrote:
>>> This patch moves label common_interrupt from asm_defns.h to entry.S
>>>
>>> Signed-off-by: Feng Wu <feng.wu@intel.com>
>> I am fairly sure the __asm__(".section .text"); was bogus, given no
>> obvious special case hacks play with the sections of this file.
> I'm fairly sure it's needed, and - what may make things worse - only
> with some compiler versions: If the compiler emitted any data before
> processing the file scope asm()s, the code generated here would end
> up in that data section.
>
> Jan

Ah ok.  In which case it needs to be kept until all the interrupt logic
has moved.

~Andrew