From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v3 7/9] x86: Enable Supervisor Mode Access
 Prevention (SMAP) for Xen
Date: Mon, 28 Apr 2014 10:53:15 +0100
Message-ID: <535E250B.10900@citrix.com>
References: <1398655043-6162-1-git-send-email-feng.wu@intel.com>
	<535E3E45020000780000CC51@nat28.tlf.novell.com>
	<535E23DF.3090903@citrix.com>
	<E959C4978C3B6342920538CF579893F001F487EF@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <E959C4978C3B6342920538CF579893F001F487EF@SHSMSX104.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Wu, Feng" <feng.wu@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>, "ian.campbell@citrix.com" <ian.campbell@citrix.com>, "Dong,
	Eddie" <eddie.dong@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Jan Beulich <JBeulich@suse.com>, "Nakajima, Jun" <jun.nakajima@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 28/04/14 10:50, Wu, Feng wrote:
>>>>      if ( unlikely(current->domain->arch.suppress_spurious_page_faults) )
>>>>      {
>>>> -        pf_type = spurious_page_fault(addr, error_code);
>>>> -        if ( pf_type == smep_fault )
>>>> +        pf_type = spurious_page_fault(addr, regs);
>>>> +        if ( (pf_type == smep_fault) || (pf_type == smap_fault))
>>>>          {
>>>> -            gdprintk(XENLOG_ERR, "Fatal SMEP fault\n");
>>>> +            printk(XENLOG_G_ERR "%p fatal %s fault\n",
>>>> +                   current, (pf_type == smep_fault) ? "SMEP" :
>> "SMAP");
>>
>> That should be %pv rather than %p, which is an automagic format
>> parameter which will get you "d<domid>v<vcpuid>" formatted.
> Thanks Andrew, I thought it was a typo in your last review:)

We are slowly accumulating useful custom %p formatting, similar to Linux.

docs/misc/printk-formats.txt shows the current extensions supported.

~Andrew