From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] xen/arm64: disable alignment check
Date: Mon, 28 Apr 2014 11:37:55 +0100
Message-ID: <535E2F83.8030901@citrix.com>
References: <1398589848-14731-1-git-send-email-murzin.v@gmail.com>	
	<1398678492.29700.24.camel@kazak.uk.xensource.com>	
	<535E2C50.6090602@citrix.com>
	<1398681362.29700.50.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1Weiwi-0007Mr-1F
	for xen-devel@lists.xenproject.org; Mon, 28 Apr 2014 10:38:00 +0000
In-Reply-To: <1398681362.29700.50.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, Vladimir Murzin <murzin.v@gmail.com>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 28/04/14 11:36, Ian Campbell wrote:
> On Mon, 2014-04-28 at 11:24 +0100, David Vrabel wrote:
>> On 28/04/14 10:48, Ian Campbell wrote:
>>> On Sun, 2014-04-27 at 10:10 +0100, Vladimir Murzin wrote:
>>>> Alignment check is enabled by default at Xen boot.
>>>
>>> This has already been disabled in the development branch via:
>>> commit 58bbe7d71239db508c30099bf7b6db7c458f3336
>>> Author: Ian Campbell <ian.campbell@citrix.com>
>>> Date:   Wed Mar 26 13:38:45 2014 +0000
>>>
>>>     xen: arm64: disable alignment traps
>>>     
>>>     The mem* primitives which I am about to import from Linux in a subsequent
>>>     patch rely on the hardware handling misalignment.
>>>     
>>>     The benefits of an optimised memcpy etc outweigh the downsides.
>>>     
>>>     Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>>>     Acked-by: Julien Grall <julien.grall@linaro.org>
>>>     Acked-by: Tim Deegan <tim@xen.org>
>>>
>>> I will consider this for backport, but first I'd like to consider
>>> whether we shouldn't fix the hypervisor side evtchn FIFO code along the
>>> same lines as the kernel side. David, any thoughts?
>>
>> I believe Jan suggested making Xen's bitops handle 32-bit alignment or
>> adding a new set of 32-bit bitops.
> 
> This is already the case for the arm64 bitops, we deliberately diverged
> from Linux here because there are a bunch of other "misaligned" 4-byte
> bitmasks (one in the malloc implementation springs to mind).

Then I'm not sure what it is you're trying to fix in Xen?

David