From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 2/4] x86/boot: Early data should live in init.data Date: Mon, 28 Apr 2014 11:41:09 +0100 Message-ID: <535E3045.2040001@citrix.com> References: <1398455459-8431-1-git-send-email-andrew.cooper3@citrix.com> <1398455459-8431-3-git-send-email-andrew.cooper3@citrix.com> <535E44AE020000780000CD00@nat28.tlf.novell.com> <535E2A60.8040002@citrix.com> <535E4B9B020000780000CD86@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <535E4B9B020000780000CD86@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Xen-devel List-Id: xen-devel@lists.xenproject.org On 28/04/14 11:37, Jan Beulich wrote: >>>> On 28.04.14 at 12:16, wrote: >> On 28/04/14 11:08, Jan Beulich wrote: >>>>>> On 25.04.14 at 21:50, wrote: >>>> --- a/xen/arch/x86/boot/head.S >>>> +++ b/xen/arch/x86/boot/head.S >>>> @@ -32,11 +32,17 @@ ENTRY(start) >>>> /* Checksum: must be the negated sum of the first two fields. */ >>>> .long -(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS) >>>> >>>> - .section .init.text, "ax" >>>> + .section .init.data, "aw", @progbits >>>> + >>>> +gdt_boot_descr: >>>> + .word 6*8-1 >>>> + .long sym_phys(trampoline_gdt) >>> While at it, how about putting this on a 2 mod 4 boundary? >> Yes, and the strings below into .rodata > Actually not just them - the construct above is read-only too afaict. > > Jan Yes - I noticed as much when starting to implement the changed. ~Andrew