From: George Cherian <george.cherian-l0cyMroinI0@public.gmane.org>
To: "Guido Martínez"
<guido-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"Ezequiel García"
<ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
Subject: Re: [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs
Date: Mon, 28 Apr 2014 20:11:33 +0530 [thread overview]
Message-ID: <535E689D.7010204@ti.com> (raw)
In-Reply-To: <1398693512-5355-1-git-send-email-guido-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
On 4/28/2014 7:28 PM, Guido Martínez wrote:
> Use phandles instead of unit adresses to reference usb and dma nodes.
> This makes the DT more robust and readable.
The series will give dtb build errors
Error: arch/arm/boot/dts/am335x-bone-common.dtsi:186.2-15 syntax error
FATAL ERROR: Unable to parse input tree
Error: arch/arm/boot/dts/am335x-evmsk.dts:367.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-bone.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
Error: arch/arm/boot/dts/am335x-evm.dts:334.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-evmsk.dtb] Error 1
make[1]: *** [arch/arm/boot/dts/am335x-evm.dtb] Error 1
Error: arch/arm/boot/dts/am335x-igep0033.dtsi:204.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-base0033.dtb] Error 1
Error: arch/arm/boot/dts/am335x-bone-common.dtsi:186.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-boneblack.dtb] Error 1
make: *** [dtbs] Error 2
>
> Signed-off-by: Guido Martínez <guido-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
> ---
> arch/arm/boot/dts/am335x-bone-common.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index 2e7d932..b95bc9a 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -183,28 +183,28 @@
> &usb {
> status = "okay";
>
> - control@44e10620 {
> + &usb_ctrl_mod {
> status = "okay";
> };
>
> - usb-phy@47401300 {
> + &usb0_phy {
> status = "okay";
> };
>
> - usb-phy@47401b00 {
> + &usb1_phy {
> status = "okay";
> };
>
> - usb@47401000 {
> + &usb0 {
> status = "okay";
> };
>
> - usb@47401800 {
> + &usb1 {
> status = "okay";
> dr_mode = "host";
> };
>
> - dma-controller@47402000 {
> + &cppi41dma {
> status = "okay";
> };
> };
Instead the patch should be
diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi
b/arch/arm/boot/dts/am335x-bone-common.dtsi
index 2e7d932..06be20a 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -182,31 +182,30 @@
&usb {
status = "okay";
+};
+&usb_ctrl_mod {
+ status = "okay";
+};
- control@44e10620 {
- status = "okay";
- };
-
- usb-phy@47401300 {
- status = "okay";
- };
+&usb0_phy {
+ status = "okay";
+};
- usb-phy@47401b00 {
- status = "okay";
- };
+&usb1_phy {
+ status = "okay";
+};
- usb@47401000 {
- status = "okay";
- };
+&usb {
+ status = "okay";
+};
- usb@47401800 {
- status = "okay";
- dr_mode = "host";
- };
+&usb1 {
+ status = "okay";
+ dr_mode = "host";
+};
- dma-controller@47402000 {
- status = "okay";
- };
+&cppi41dma {
+ status = "okay";
};
--
-George
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: george.cherian@ti.com (George Cherian)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs
Date: Mon, 28 Apr 2014 20:11:33 +0530 [thread overview]
Message-ID: <535E689D.7010204@ti.com> (raw)
In-Reply-To: <1398693512-5355-1-git-send-email-guido@vanguardiasur.com.ar>
On 4/28/2014 7:28 PM, Guido Mart?nez wrote:
> Use phandles instead of unit adresses to reference usb and dma nodes.
> This makes the DT more robust and readable.
The series will give dtb build errors
Error: arch/arm/boot/dts/am335x-bone-common.dtsi:186.2-15 syntax error
FATAL ERROR: Unable to parse input tree
Error: arch/arm/boot/dts/am335x-evmsk.dts:367.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-bone.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
Error: arch/arm/boot/dts/am335x-evm.dts:334.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-evmsk.dtb] Error 1
make[1]: *** [arch/arm/boot/dts/am335x-evm.dtb] Error 1
Error: arch/arm/boot/dts/am335x-igep0033.dtsi:204.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-base0033.dtb] Error 1
Error: arch/arm/boot/dts/am335x-bone-common.dtsi:186.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-boneblack.dtb] Error 1
make: *** [dtbs] Error 2
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> ---
> arch/arm/boot/dts/am335x-bone-common.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index 2e7d932..b95bc9a 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -183,28 +183,28 @@
> &usb {
> status = "okay";
>
> - control at 44e10620 {
> + &usb_ctrl_mod {
> status = "okay";
> };
>
> - usb-phy at 47401300 {
> + &usb0_phy {
> status = "okay";
> };
>
> - usb-phy at 47401b00 {
> + &usb1_phy {
> status = "okay";
> };
>
> - usb at 47401000 {
> + &usb0 {
> status = "okay";
> };
>
> - usb at 47401800 {
> + &usb1 {
> status = "okay";
> dr_mode = "host";
> };
>
> - dma-controller at 47402000 {
> + &cppi41dma {
> status = "okay";
> };
> };
Instead the patch should be
diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi
b/arch/arm/boot/dts/am335x-bone-common.dtsi
index 2e7d932..06be20a 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -182,31 +182,30 @@
&usb {
status = "okay";
+};
+&usb_ctrl_mod {
+ status = "okay";
+};
- control at 44e10620 {
- status = "okay";
- };
-
- usb-phy at 47401300 {
- status = "okay";
- };
+&usb0_phy {
+ status = "okay";
+};
- usb-phy at 47401b00 {
- status = "okay";
- };
+&usb1_phy {
+ status = "okay";
+};
- usb at 47401000 {
- status = "okay";
- };
+&usb {
+ status = "okay";
+};
- usb at 47401800 {
- status = "okay";
- dr_mode = "host";
- };
+&usb1 {
+ status = "okay";
+ dr_mode = "host";
+};
- dma-controller at 47402000 {
- status = "okay";
- };
+&cppi41dma {
+ status = "okay";
};
--
-George
WARNING: multiple messages have this Message-ID (diff)
From: George Cherian <george.cherian@ti.com>
To: "Guido Martínez" <guido@vanguardiasur.com.ar>,
LKML <linux-kernel@vger.kernel.org>,
bcousson@baylibre.com, tony@atomide.com
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Ezequiel García" <ezequiel@vanguardiasur.com.ar>
Subject: Re: [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs
Date: Mon, 28 Apr 2014 20:11:33 +0530 [thread overview]
Message-ID: <535E689D.7010204@ti.com> (raw)
In-Reply-To: <1398693512-5355-1-git-send-email-guido@vanguardiasur.com.ar>
On 4/28/2014 7:28 PM, Guido Martínez wrote:
> Use phandles instead of unit adresses to reference usb and dma nodes.
> This makes the DT more robust and readable.
The series will give dtb build errors
Error: arch/arm/boot/dts/am335x-bone-common.dtsi:186.2-15 syntax error
FATAL ERROR: Unable to parse input tree
Error: arch/arm/boot/dts/am335x-evmsk.dts:367.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-bone.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
Error: arch/arm/boot/dts/am335x-evm.dts:334.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-evmsk.dtb] Error 1
make[1]: *** [arch/arm/boot/dts/am335x-evm.dtb] Error 1
Error: arch/arm/boot/dts/am335x-igep0033.dtsi:204.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-base0033.dtb] Error 1
Error: arch/arm/boot/dts/am335x-bone-common.dtsi:186.2-15 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [arch/arm/boot/dts/am335x-boneblack.dtb] Error 1
make: *** [dtbs] Error 2
>
> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
> ---
> arch/arm/boot/dts/am335x-bone-common.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index 2e7d932..b95bc9a 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -183,28 +183,28 @@
> &usb {
> status = "okay";
>
> - control@44e10620 {
> + &usb_ctrl_mod {
> status = "okay";
> };
>
> - usb-phy@47401300 {
> + &usb0_phy {
> status = "okay";
> };
>
> - usb-phy@47401b00 {
> + &usb1_phy {
> status = "okay";
> };
>
> - usb@47401000 {
> + &usb0 {
> status = "okay";
> };
>
> - usb@47401800 {
> + &usb1 {
> status = "okay";
> dr_mode = "host";
> };
>
> - dma-controller@47402000 {
> + &cppi41dma {
> status = "okay";
> };
> };
Instead the patch should be
diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi
b/arch/arm/boot/dts/am335x-bone-common.dtsi
index 2e7d932..06be20a 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -182,31 +182,30 @@
&usb {
status = "okay";
+};
+&usb_ctrl_mod {
+ status = "okay";
+};
- control@44e10620 {
- status = "okay";
- };
-
- usb-phy@47401300 {
- status = "okay";
- };
+&usb0_phy {
+ status = "okay";
+};
- usb-phy@47401b00 {
- status = "okay";
- };
+&usb1_phy {
+ status = "okay";
+};
- usb@47401000 {
- status = "okay";
- };
+&usb {
+ status = "okay";
+};
- usb@47401800 {
- status = "okay";
- dr_mode = "host";
- };
+&usb1 {
+ status = "okay";
+ dr_mode = "host";
+};
- dma-controller@47402000 {
- status = "okay";
- };
+&cppi41dma {
+ status = "okay";
};
--
-George
next prev parent reply other threads:[~2014-04-28 14:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 13:58 [PATCH 1/4] ARM: dts: am335x-bone-common: use phandles for USB and DMA refs Guido Martínez
2014-04-28 13:58 ` Guido Martínez
2014-04-28 13:58 ` Guido Martínez
2014-04-28 13:58 ` [PATCH 2/4] ARM: dts: am335x-evm: " Guido Martínez
2014-04-28 13:58 ` Guido Martínez
2014-04-28 13:58 ` Guido Martínez
2014-05-06 16:16 ` Felipe Balbi
2014-05-06 16:16 ` Felipe Balbi
2014-04-28 13:58 ` [PATCH 3/4] ARM: dts: am335x-evmsk: " Guido Martínez
2014-04-28 13:58 ` Guido Martínez
2014-05-06 16:16 ` Felipe Balbi
2014-05-06 16:16 ` Felipe Balbi
2014-04-28 13:58 ` [PATCH 4/4] ARM: dts: am335x-igep0033: " Guido Martínez
2014-04-28 13:58 ` Guido Martínez
2014-05-06 16:17 ` Felipe Balbi
2014-05-06 16:17 ` Felipe Balbi
[not found] ` <1398693512-5355-1-git-send-email-guido-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
2014-04-28 14:41 ` George Cherian [this message]
2014-04-28 14:41 ` [PATCH 1/4] ARM: dts: am335x-bone-common: " George Cherian
2014-04-28 14:41 ` George Cherian
[not found] ` <535E689D.7010204-l0cyMroinI0@public.gmane.org>
2014-04-28 16:10 ` Guido Martínez
2014-04-28 16:10 ` Guido Martínez
2014-04-28 16:10 ` Guido Martínez
2014-04-28 20:54 ` [PATCH v2 " Guido Martínez
2014-04-28 20:54 ` [PATCH v2 2/4] ARM: dts: am335x-evm: " Guido Martínez
2014-05-06 16:18 ` Felipe Balbi
2014-04-28 20:54 ` [PATCH v2 3/4] ARM: dts: am335x-evmsk: " Guido Martínez
2014-05-06 16:18 ` Felipe Balbi
2014-04-28 20:54 ` [PATCH v2 4/4] ARM: dts: am335x-igep0033: " Guido Martínez
2014-05-06 16:18 ` Felipe Balbi
2014-05-06 16:17 ` [PATCH v2 1/4] ARM: dts: am335x-bone-common: " Felipe Balbi
2014-05-06 16:37 ` Tony Lindgren
2014-05-06 16:16 ` [PATCH " Felipe Balbi
2014-05-06 16:16 ` Felipe Balbi
2014-05-06 16:16 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535E689D.7010204@ti.com \
--to=george.cherian-l0cymroini0@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=guido-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.