From: Dave Hansen <dave.hansen@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, intel-gfx@lists.freedesktop.org,
Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Dave Chinner <dchinner@redhat.com>,
Glauber Costa <glommer@openvz.org>,
Hugh Dickins <hughd@google.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] mm: Throttle shrinkers harder
Date: Mon, 28 Apr 2014 09:38:41 -0700 [thread overview]
Message-ID: <535E8411.3050304@intel.com> (raw)
In-Reply-To: <20140426131026.GA4418@nuc-i3427.alporthouse.com>
On 04/26/2014 06:10 AM, Chris Wilson wrote:
>>> > > Thanks for the pointer to
>>> > > register_oom_notifier(), I can use that to make sure that we do purge
>>> > > everything from the GPU, and do a sanity check at the same time, before
>>> > > we start killing processes.
>> >
>> > Actually, that one doesn't get called until we're *SURE* we are going to
>> > OOM. Any action taken in there won't be taken in to account.
> blocking_notifier_call_chain(&oom_notify_list, 0, &freed);
> if (freed > 0)
> /* Got some memory back in the last second. */
> return;
>
> That looks like it should abort the oom and so repeat the allocation
> attempt? Or is that too hopeful?
You're correct. I was reading the code utterly wrong.
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, intel-gfx@lists.freedesktop.org,
Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Dave Chinner <dchinner@redhat.com>,
Glauber Costa <glommer@openvz.org>,
Hugh Dickins <hughd@google.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] mm: Throttle shrinkers harder
Date: Mon, 28 Apr 2014 09:38:41 -0700 [thread overview]
Message-ID: <535E8411.3050304@intel.com> (raw)
In-Reply-To: <20140426131026.GA4418@nuc-i3427.alporthouse.com>
On 04/26/2014 06:10 AM, Chris Wilson wrote:
>>> > > Thanks for the pointer to
>>> > > register_oom_notifier(), I can use that to make sure that we do purge
>>> > > everything from the GPU, and do a sanity check at the same time, before
>>> > > we start killing processes.
>> >
>> > Actually, that one doesn't get called until we're *SURE* we are going to
>> > OOM. Any action taken in there won't be taken in to account.
> blocking_notifier_call_chain(&oom_notify_list, 0, &freed);
> if (freed > 0)
> /* Got some memory back in the last second. */
> return;
>
> That looks like it should abort the oom and so repeat the allocation
> attempt? Or is that too hopeful?
You're correct. I was reading the code utterly wrong.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-04-28 16:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 7:05 [PATCH] mm: Throttle shrinkers harder Chris Wilson
2014-04-18 19:14 ` Andrew Morton
2014-04-22 19:30 ` Daniel Vetter
2014-04-22 19:30 ` Daniel Vetter
2014-04-23 21:14 ` Dave Hansen
2014-04-24 5:58 ` Chris Wilson
2014-04-24 5:58 ` Chris Wilson
2014-04-24 15:21 ` Dave Hansen
2014-04-24 15:39 ` Chris Wilson
2014-04-24 15:39 ` Chris Wilson
2014-04-24 22:35 ` Dave Hansen
2014-04-24 22:35 ` Dave Hansen
2014-04-25 7:23 ` Chris Wilson
2014-04-25 7:23 ` Chris Wilson
2014-04-25 17:18 ` Dave Hansen
2014-04-25 17:56 ` Dave Hansen
2014-04-26 13:10 ` Chris Wilson
2014-04-26 13:10 ` Chris Wilson
2014-04-28 16:38 ` Dave Hansen [this message]
2014-04-28 16:38 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535E8411.3050304@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=dchinner@redhat.com \
--cc=glommer@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.