All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Marat Radchenko <marat@slonopotamus.org>,
	GIT Mailing-list <git@vger.kernel.org>
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH 03/12] MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64
Date: Mon, 28 Apr 2014 21:59:39 +0200	[thread overview]
Message-ID: <535EB32B.4050209@web.de> (raw)
In-Reply-To: <1398693097-24651-4-git-send-email-marat@slonopotamus.org>

On 2014-04-28 15.51, Marat Radchenko wrote:
> mingw-w64 has lseek defined in io.h.
[]
>  #define off_t off64_t
> +#ifndef lseek
>  #define lseek _lseeki64
> +#endif
Is the commit message in line with the code?

I would have expected something in this style:

#if defined(__x86_64__) && ! defined(lseek))
#include <io.h>
#endif 

  parent reply	other threads:[~2014-04-28 19:59 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28 13:51 [RFC/PATCH v1] Towards MinGW(-W64) cross-compilation Marat Radchenko
2014-04-28 13:51 ` [PATCH 01/12] MINGW: config.mak.uname: add explicit way to request MinGW-build Marat Radchenko
2014-04-28 16:12   ` Jonathan Nieder
2014-04-28 13:51 ` [PATCH 02/12] MINGW: compat/bswap.h: include stdint.h Marat Radchenko
2014-04-28 14:45   ` Erik Faye-Lund
2014-04-28 14:52     ` Marat Radchenko
2014-04-28 14:54       ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 03/12] MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64 Marat Radchenko
2014-04-28 15:02   ` Erik Faye-Lund
2014-04-28 15:09     ` Marat Radchenko
2014-04-28 15:19       ` Erik Faye-Lund
2014-04-28 19:59   ` Torsten Bögershausen [this message]
2014-04-28 19:58     ` Felipe Contreras
2014-04-28 20:13     ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 04/12] Makefile: introduce CROSS_COMPILE variable Marat Radchenko
2014-04-28 16:25   ` Jonathan Nieder
2014-04-28 17:34     ` Felipe Contreras
2014-04-28 20:40     ` Marat Radchenko
2014-04-28 20:45       ` Jonathan Nieder
2014-04-28 20:54         ` Marat Radchenko
2014-04-28 17:37   ` Felipe Contreras
2014-04-28 18:15     ` Marat Radchenko
2014-04-28 18:09       ` Felipe Contreras
2014-04-28 23:38       ` Jonathan Nieder
2014-04-28 23:54         ` Felipe Contreras
2014-04-28 13:51 ` [PATCH 05/12] MINGW: git-compat-util.h: use inttypes.h for printf macros Marat Radchenko
2014-04-28 14:53   ` Erik Faye-Lund
2014-04-28 15:00     ` Marat Radchenko
2014-04-28 15:07       ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 06/12] MSVC: config.mak.uname: drop -D__USE_MINGW_ACCESS from compile definitions Marat Radchenko
2014-04-28 15:32   ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings Marat Radchenko
2014-04-28 14:58   ` Erik Faye-Lund
2014-04-28 15:04     ` Marat Radchenko
2014-04-28 15:17       ` Erik Faye-Lund
2014-04-28 16:42         ` Marat Radchenko
2014-04-28 13:51 ` [PATCH 08/12] MINGW: config.mak.uname allow using CURL for non-msysGit builds Marat Radchenko
2014-04-28 15:26   ` Erik Faye-Lund
2014-04-28 16:23     ` Marat Radchenko
2014-04-28 16:24       ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 09/12] MINGW: config.mak.uname: drop -DNOGDI Marat Radchenko
2014-04-28 14:56   ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 10/12] MINGW: config.mak.uname: drop USE_NED_ALLOCATOR Marat Radchenko
2014-04-28 15:23   ` Erik Faye-Lund
2014-04-28 16:30     ` Jonathan Nieder
2014-04-29  7:48     ` Marat Radchenko
2014-04-29  7:59       ` Felipe Contreras
2014-04-28 17:39   ` Felipe Contreras
2014-04-28 19:50     ` Philip Oakley
2014-04-28 13:51 ` [PATCH 11/12] MINGW: do not fail at redefining pid_t on MinGW-W64 Marat Radchenko
2014-04-28 15:24   ` Erik Faye-Lund
2014-04-28 13:51 ` [PATCH 12/12] MINGW: compat/mingw.h: drop fork() definition Marat Radchenko
2014-04-28 15:20   ` Erik Faye-Lund
2014-04-28 15:34 ` [RFC/PATCH v1] Towards MinGW(-W64) cross-compilation Erik Faye-Lund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535EB32B.4050209@web.de \
    --to=tboegi@web.de \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=marat@slonopotamus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.