Re: [PATCH V6] rrdtool: enable perl and python bindings

[Chong Lu <Chong.Lu@windriver.com>]

On 04/29/2014 03:45 PM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Chong Lu schreef op 29-04-14 09:22:
>> 1. default enable perl and python bindings 2. rrdtool uses perl.real,
>> perl.real doesn't know where the PERL5LIB should be when prebuilts are
>> used. Use the wrapper perl instead, perl sets PERL5LIB and invokes
>> perl.real 3. While using dash as /bin/sh, subsequent commands in
>> functions will not use the environment variables passed to the function
>> call line unless explicitly run "export ENV_VAR". 4. delete unrecognized
>> options: "--enable-local-libpng" and "--enable-local-zlib"
>>
>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com> ---
>> meta-oe/recipes-extended/rrdtool/rrdtool_1.4.7.bb |   92
>> +++++++++++++++++++-- 1 file changed, 86 insertions(+), 6 deletions(-)
>>
>> diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.4.7.bb
>> b/meta-oe/recipes-extended/rrdtool/rrdtool_1.4.7.bb index
>> 533451f..e337529 100644 ---
>> a/meta-oe/recipes-extended/rrdtool/rrdtool_1.4.7.bb +++
>> b/meta-oe/recipes-extended/rrdtool/rrdtool_1.4.7.bb @@ -15,25 +15,105 @@
>> SRC_URI = "http://oss.oetiker.ch/rrdtool/pub/rrdtool-${PV}.tar.gz \
>> +PACKAGES += "${PN}-perl ${PN}-python"
> That needs to move below do_install, since it's a packaging var
> (PACKAGE_CONFIG is actually recipe-config, so those go above do_configure).
> Also, do you need =+ here instead of +=?
Ok, thanks.
=+ is better here.

Chong
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
>
> iD8DBQFTX1iBMkyGM64RGpERAg1aAJ0YiuDvRTjWQzenMhHx9RSdCmW1aQCdF/zD
> Ow07E6UIg9o56HoTzQrQ14U=
> =fzFu
> -----END PGP SIGNATURE-----
>