From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: exynos: remove the unused code
Date: Tue, 29 Apr 2014 10:15:21 +0200 [thread overview]
Message-ID: <535F5F99.8050601@samsung.com> (raw)
In-Reply-To: <535F5E41.4010307@samsung.com>
Hello Jaehoon,
On 04/29/2014 10:09 AM, Jaehoon Chung wrote:
> "mmc boot" command didn't use anywhere.
> It can be replaced to "mmc dev" command.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> include/configs/s5pc210_universal.h | 7 ++-----
> include/configs/trats.h | 7 ++-----
> include/configs/trats2.h | 11 +++--------
> 3 files changed, 7 insertions(+), 18 deletions(-)
>
> diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h
> index 2da8871..db5561a 100644
> --- a/include/configs/s5pc210_universal.h
> +++ b/include/configs/s5pc210_universal.h
> @@ -111,12 +111,9 @@
> "onenand write 0x41008000 0xc00000 0x500000\0" \
> "bootk=" \
> "run loaduimage; bootm 0x40007FC0\0" \
> - "updatemmc=" \
> - "mmc boot 0 1 1 1; mmc write 0 0x42008000 0 0x200;" \
> - "mmc boot 0 1 1 0\0" \
> "updatebackup=" \
> - "mmc boot 0 1 1 2; mmc write 0 0x42100000 0 0x200;" \
> - "mmc boot 0 1 1 0\0" \
> + "mmc dev 0 2; mmc write 0 0x42100000 0 0x200;" \
> + "mmc dev 0 0\0" \
> "updatebootb=" \
> "mmc read 0 0x42100000 0x80 0x200; run updatebackup\0" \
> "lpj=lpj=3981312\0" \
> diff --git a/include/configs/trats.h b/include/configs/trats.h
> index 5d8bd60..694c29c 100644
> --- a/include/configs/trats.h
> +++ b/include/configs/trats.h
> @@ -121,12 +121,9 @@
> "bootm 0x40007FC0 - ${fdtaddr};" \
> "fi;" \
> "bootm 0x40007FC0;\0" \
> - "updatemmc=" \
> - "mmc boot 0 1 1 1; mmc write 0 0x42008000 0 0x200;" \
> - "mmc boot 0 1 1 0\0" \
> "updatebackup=" \
> - "mmc boot 0 1 1 2; mmc write 0 0x42100000 0 0x200;" \
> - "mmc boot 0 1 1 0\0" \
> + "mmc dev 0 2; mmc write 0 0x42100000 0 0x200;" \
> + "mmc dev 0 0\0" \
> "updatebootb=" \
> "mmc read 0 0x42100000 0x80 0x200; run updatebackup\0" \
> "lpj=lpj=3981312\0" \
> diff --git a/include/configs/trats2.h b/include/configs/trats2.h
> index 53d449c..e7a4107 100644
> --- a/include/configs/trats2.h
> +++ b/include/configs/trats2.h
> @@ -111,16 +111,11 @@
> "bootm 0x40007FC0 - ${fdtaddr};" \
> "fi;" \
> "bootm 0x40007FC0;\0" \
> - "updatemmc=" \
> - "mmc boot 0 1 1 1; mmc write 0x42008000 0 0x200;" \
> - "mmc boot 0 1 1 0\0" \
> "updatebackup=" \
> - "mmc boot 0 1 1 2; mmc write 0x42100000 0 0x200;" \
> - " mmc boot 0 1 1 0\0" \
> + "mmc dev 0 2; mmc write 0x52100000 0 0x800;" \
> + " mmc dev 0 0\0" \
> "updatebootb=" \
> - "mmc read 0x51000000 0x80 0x200; run updatebackup\0" \
> - "updateuboot=" \
> - "mmc write 0x50000000 0x80 0x400\0" \
> + "mmc read 0x51000000 0x80 0x800; run updatebackup\0" \
Are you sure that this works fine?
You load u-boot at 0x51... and then in updatebackup you write it to mmc
from another address (0x521...), so it's probably by mistake.
> "mmcboot=" \
> "setenv bootargs root=/dev/mmcblk${mmcdev}p${mmcrootpart} " \
> "${lpj} rootwait ${console} ${meminfo} ${opts} ${lcdinfo}; " \
>
Thanks
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
next prev parent reply other threads:[~2014-04-29 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 8:09 [U-Boot] [PATCH] ARM: exynos: remove the unused code Jaehoon Chung
2014-04-29 8:15 ` Przemyslaw Marczak [this message]
2014-04-29 8:22 ` Jaehoon Chung
-- strict thread matches above, loose matches on Subject: below --
2014-04-16 8:10 Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535F5F99.8050601@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.