From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v4] hypercall/mem: Introduce
	XENMEM_machphys_compat_mfn_list
Date: Tue, 29 Apr 2014 10:59:59 +0100
Message-ID: <535F781F.1080508@citrix.com>
References: <1398764794-25380-1-git-send-email-andrew.cooper3@citrix.com>
	<535F9406020000780000D460@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <535F9406020000780000D460@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 29/04/14 10:59, Jan Beulich wrote:
>>>> On 29.04.14 at 11:46, <andrew.cooper3@citrix.com> wrote:
>> Changes in v4:
>>  * Use same visibility as XENMEM_machphys_mfn_list.  Leave note about next
>>    subop.
> I'm fine with this now with one possible minor correction (could be done
> while committing, so no need to resubmit just because of this):
>
>> --- a/xen/include/public/memory.h
>> +++ b/xen/include/public/memory.h
>> @@ -187,6 +187,16 @@ typedef struct xen_machphys_mfn_list xen_machphys_mfn_list_t;
>>  DEFINE_XEN_GUEST_HANDLE(xen_machphys_mfn_list_t);
>>  
>>  /*
>> + * For a compat toolstack domain, this is identical to
>> + * XENMEM_machphys_mfn_list.
>> + *
>> + * For a non compat toolstack domain, this functions similarly to
>> + * XENMEM_machphys_mfn_list, but returns the mfns making up the compatibility
>> + * m2p table.
>> + */
>> +#define XENMEM_machphys_compat_mfn_list     25
> I think it is now at least misleading to say "toolstack domain" in the
> comment above - in both cases I'd prefer this to just say "caller".
>
> Jan
>

Ok - I am happy with that.

~Andrew