From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed Date: Tue, 29 Apr 2014 12:57:24 +0200 Message-ID: <535F8594.40609@metafoo.de> References: <6606961.lAGLvkNsEj@wuerfel> <6285923.UQqcZVikjI@wuerfel> <1398740853.880576398@f238.i.mail.ru> <4270904.84oGcCXL4B@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp-out-008.synserver.de (smtp-out-063.synserver.de [212.40.185.63]) by alsa0.perex.cz (Postfix) with ESMTP id 0AB26264F3F for ; Tue, 29 Apr 2014 12:57:31 +0200 (CEST) In-Reply-To: <4270904.84oGcCXL4B@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Arnd Bergmann Cc: alsa-devel@alsa-project.org, Alexander Shiyan , linux-arm-kernel@lists.infradead.org, Mark Brown List-Id: alsa-devel@alsa-project.org T24gMDQvMjkvMjAxNCAxMjozNyBQTSwgQXJuZCBCZXJnbWFubiB3cm90ZToKPiBPbiBUdWVzZGF5 IDI5IEFwcmlsIDIwMTQgMDc6MDc6MzMgQWxleGFuZGVyIFNoaXlhbiB3cm90ZToKPj4gTW9uLCAy OCBBcHIgMjAxNCAyMzoxMjoxNCArMDIwMCDQvtGCIEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIu ZGU+Ogo+Pj4gT24gVHVlc2RheSAyOSBBcHJpbCAyMDE0IDAwOjM1OjQxIEFsZXhhbmRlciBTaGl5 YW4gd3JvdGU6Cj4+Pj4KPj4+PiBTbywgSSBkb24ndCB1bmRlcnN0YW5kIHdoeSB0aGlzIGVycm9y IGhhcHBlbiwgYXMgd2VsbCBhcyBJIGNhbiBub3QKPj4+PiByZXByb2R1Y2UgdGhpcy4uLgo+Pj4K Pj4+IEl0J3MgcHJvYmFibHkgQ09ORklHX1NORF9TT0NfSU1YX1BDTV9ETUE9bSBhbmQgQ09ORklH X1NORF9TT0NfRlNMX1NTST15IHRoZW4uCj4+PiBXaGF0IGlzIHRoZSBpbnRlbmRlZCBiZWhhdmlv ciBpbiB0aGlzIGNhc2U/IFNob3VsZCBDT05GSUdfU05EX1NPQ19GU0xfU1NJCj4+PiBiZSBmb3Jj ZWQgdG8gYmUgYSBtb2R1bGUgYXMgd2VsbD8KPj4KPj4gSG1tLCB5ZXMuLi4KPj4gSSB0aG91Z2h0 IHRoYXQgSSBoYWQgYWxyZWFkeSBzb2x2ZWQgYSBzaW1pbGFyIHByb2JsZW0gZm9yIHRoZSBlYXJs aWVyCj4+IHZlcnNpb24gb2YgdGhlIHBhdGNoIC4uLgo+Cj4gSG93IGFib3V0IHRoaXM/CgpIYXZp bmcgRlNMX1NTSS9GU0xfU1BESUYsIGJ1dCBub3QgU05EX1NPQ19JTVhfUENNX0RNQSBkb2VzIG5v dCBtYWtlIHNlbnNlIG9uIAppTVguClNvIGhvdyBhYm91dDoKCglzZWxlY3QgU05EX1NPQ19JTVhf UENNX0RNQSBpZiBTTkRfSU1YX1NPQwoKYW5kIHJlbW92ZSBhbGwgdGhlIG90aGVyICdzZWxlY3Qg U05EX1NPQ19JTVhfUENNX0RNQScgc3RhdGVtZW50cy4gVGhhdCdzIGluIApteSBvcGluaW9uIG11 Y2ggbmljZXIuCgotIExhcnMKCgo+Cj4gU2lnbmVkLW9mZi1ieTogQXJuZCBCZXJnbWFubiA8YXJu ZEBhcm5kYi5kZT4KPgo+IGRpZmYgLS1naXQgYS9zb3VuZC9zb2MvZnNsL0tjb25maWcgYi9zb3Vu ZC9zb2MvZnNsL0tjb25maWcKPiBpbmRleCBmYjI2MzQ1Li5hZjBiYjkyIDEwMDY0NAo+IC0tLSBh L3NvdW5kL3NvYy9mc2wvS2NvbmZpZwo+ICsrKyBiL3NvdW5kL3NvYy9mc2wvS2NvbmZpZwo+IEBA IC05LDYgKzksNyBAQCBjb25maWcgU05EX1NPQ19GU0xfU0FJCj4KPiAgIGNvbmZpZyBTTkRfU09D X0ZTTF9TU0kKPiAgIAl0cmlzdGF0ZSAiU3luY2hyb25vdXMgU2VyaWFsIEludGVyZmFjZSBtb2R1 bGUgc3VwcG9ydCIKPiArCWRlcGVuZHMgb24gbSB8fCBTTkRfU09DX0lNWF9QQ01fRE1BICE9IG0K PiAgIAloZWxwCj4gICAJICBTYXkgWSBpZiB5b3Ugd2FudCB0byBhZGQgU3luY2hyb25vdXMgU2Vy aWFsIEludGVyZmFjZSAoU1NJKQo+ICAgCSAgc3VwcG9ydCBmb3IgdGhlIEZyZWVzY2FsZSBDUFVz Lgo+IEBAIC0xOCw2ICsxOSw3IEBAIGNvbmZpZyBTTkRfU09DX0ZTTF9TU0kKPiAgIGNvbmZpZyBT TkRfU09DX0ZTTF9TUERJRgo+ICAgCXRyaXN0YXRlICJTb255L1BoaWxpcHMgRGlnaXRhbCBJbnRl cmZhY2UgbW9kdWxlIHN1cHBvcnQiCj4gICAJc2VsZWN0IFJFR01BUF9NTUlPCj4gKwlkZXBlbmRz IG9uIG0gfHwgU05EX1NPQ19JTVhfUENNX0RNQSAhPSBtCj4gICAJaGVscAo+ICAgCSAgU2F5IFkg aWYgeW91IHdhbnQgdG8gYWRkIFNvbnkvUGhpbGlwcyBEaWdpdGFsIEludGVyZmFjZSAoU1BESUYp Cj4gICAJICBzdXBwb3J0IGZvciB0aGUgRnJlZXNjYWxlIENQVXMuCj4KPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEFsc2EtZGV2ZWwgbWFpbGluZyBs aXN0Cj4gQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3JnCj4gaHR0cDovL21haWxtYW4uYWxzYS1w cm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwKPgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QK QWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3JnCmh0dHA6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5v cmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: lars@metafoo.de (Lars-Peter Clausen) Date: Tue, 29 Apr 2014 12:57:24 +0200 Subject: [alsa-devel] [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed In-Reply-To: <4270904.84oGcCXL4B@wuerfel> References: <6606961.lAGLvkNsEj@wuerfel> <6285923.UQqcZVikjI@wuerfel> <1398740853.880576398@f238.i.mail.ru> <4270904.84oGcCXL4B@wuerfel> Message-ID: <535F8594.40609@metafoo.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/29/2014 12:37 PM, Arnd Bergmann wrote: > On Tuesday 29 April 2014 07:07:33 Alexander Shiyan wrote: >> Mon, 28 Apr 2014 23:12:14 +0200 ?? Arnd Bergmann : >>> On Tuesday 29 April 2014 00:35:41 Alexander Shiyan wrote: >>>> >>>> So, I don't understand why this error happen, as well as I can not >>>> reproduce this... >>> >>> It's probably CONFIG_SND_SOC_IMX_PCM_DMA=m and CONFIG_SND_SOC_FSL_SSI=y then. >>> What is the intended behavior in this case? Should CONFIG_SND_SOC_FSL_SSI >>> be forced to be a module as well? >> >> Hmm, yes... >> I thought that I had already solved a similar problem for the earlier >> version of the patch ... > > How about this? Having FSL_SSI/FSL_SPDIF, but not SND_SOC_IMX_PCM_DMA does not make sense on iMX. So how about: select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC and remove all the other 'select SND_SOC_IMX_PCM_DMA' statements. That's in my opinion much nicer. - Lars > > Signed-off-by: Arnd Bergmann > > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig > index fb26345..af0bb92 100644 > --- a/sound/soc/fsl/Kconfig > +++ b/sound/soc/fsl/Kconfig > @@ -9,6 +9,7 @@ config SND_SOC_FSL_SAI > > config SND_SOC_FSL_SSI > tristate "Synchronous Serial Interface module support" > + depends on m || SND_SOC_IMX_PCM_DMA != m > help > Say Y if you want to add Synchronous Serial Interface (SSI) > support for the Freescale CPUs. > @@ -18,6 +19,7 @@ config SND_SOC_FSL_SSI > config SND_SOC_FSL_SPDIF > tristate "Sony/Philips Digital Interface module support" > select REGMAP_MMIO > + depends on m || SND_SOC_IMX_PCM_DMA != m > help > Say Y if you want to add Sony/Philips Digital Interface (SPDIF) > support for the Freescale CPUs. > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel at alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >