From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [alsa-devel] [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed Date: Tue, 29 Apr 2014 16:30:43 +0200 Message-ID: <535FB793.5050200@metafoo.de> References: <6606961.lAGLvkNsEj@wuerfel> <4270904.84oGcCXL4B@wuerfel> <535F8594.40609@metafoo.de> <4275868.O962kiiyJa@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4275868.O962kiiyJa@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Arnd Bergmann Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, Alexander Shiyan , Mark Brown List-Id: alsa-devel@alsa-project.org T24gMDQvMjkvMjAxNCAwMzozMCBQTSwgQXJuZCBCZXJnbWFubiB3cm90ZToKPiBPbiBUdWVzZGF5 IDI5IEFwcmlsIDIwMTQgMTI6NTc6MjQgTGFycy1QZXRlciBDbGF1c2VuIHdyb3RlOgo+PiBPbiAw NC8yOS8yMDE0IDEyOjM3IFBNLCBBcm5kIEJlcmdtYW5uIHdyb3RlOgo+Pj4gT24gVHVlc2RheSAy OSBBcHJpbCAyMDE0IDA3OjA3OjMzIEFsZXhhbmRlciBTaGl5YW4gd3JvdGU6Cj4+Pj4gTW9uLCAy OCBBcHIgMjAxNCAyMzoxMjoxNCArMDIwMCDQvtGCIEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIu ZGU+Ogo+Pj4+PiBPbiBUdWVzZGF5IDI5IEFwcmlsIDIwMTQgMDA6MzU6NDEgQWxleGFuZGVyIFNo aXlhbiB3cm90ZToKPj4+Pj4+Cj4+Pj4+PiBTbywgSSBkb24ndCB1bmRlcnN0YW5kIHdoeSB0aGlz IGVycm9yIGhhcHBlbiwgYXMgd2VsbCBhcyBJIGNhbiBub3QKPj4+Pj4+IHJlcHJvZHVjZSB0aGlz Li4uCj4+Pj4+Cj4+Pj4+IEl0J3MgcHJvYmFibHkgQ09ORklHX1NORF9TT0NfSU1YX1BDTV9ETUE9 bSBhbmQgQ09ORklHX1NORF9TT0NfRlNMX1NTST15IHRoZW4uCj4+Pj4+IFdoYXQgaXMgdGhlIGlu dGVuZGVkIGJlaGF2aW9yIGluIHRoaXMgY2FzZT8gU2hvdWxkIENPTkZJR19TTkRfU09DX0ZTTF9T U0kKPj4+Pj4gYmUgZm9yY2VkIHRvIGJlIGEgbW9kdWxlIGFzIHdlbGw/Cj4+Pj4KPj4+PiBIbW0s IHllcy4uLgo+Pj4+IEkgdGhvdWdodCB0aGF0IEkgaGFkIGFscmVhZHkgc29sdmVkIGEgc2ltaWxh ciBwcm9ibGVtIGZvciB0aGUgZWFybGllcgo+Pj4+IHZlcnNpb24gb2YgdGhlIHBhdGNoIC4uLgo+ Pj4KPj4+IEhvdyBhYm91dCB0aGlzPwo+Pgo+PiBIYXZpbmcgRlNMX1NTSS9GU0xfU1BESUYsIGJ1 dCBub3QgU05EX1NPQ19JTVhfUENNX0RNQSBkb2VzIG5vdCBtYWtlIHNlbnNlIG9uCj4+IGlNWC4K Pj4gU28gaG93IGFib3V0Ogo+Pgo+PiAgICAgICAgICBzZWxlY3QgU05EX1NPQ19JTVhfUENNX0RN QSBpZiBTTkRfSU1YX1NPQwo+Pgo+PiBhbmQgcmVtb3ZlIGFsbCB0aGUgb3RoZXIgJ3NlbGVjdCBT TkRfU09DX0lNWF9QQ01fRE1BJyBzdGF0ZW1lbnRzLiBUaGF0J3MgaW4KPj4gbXkgb3BpbmlvbiBt dWNoIG5pY2VyLgo+Cj4gWWVzLCBtYWtlcyBzZW5zZS4gU2hvdWxkIEkgZG8gYW5vdGhlciB2ZXJz aW9uIG9mIHRoZSBwYXRjaD8KClllcy4gVGhlIHBhdGNoIHNob3VsZCBhbHNvIGFkZCBhIHNlbGVj dCBmb3IgU05EX1NPQ19JTVhfUENNX0ZJUSBhcyB0aGF0IGlzIAp1c2VkIGluIHRoZSBzYW1lIHdh eSBpbiB0aGUgZnNsX3NzaSBkcml2ZXIuIElmIGFueWJvZHkgaXMgYWZyYWlkIHRoYXQgCnNlbGVj dGluZyBib3RoIFNORF9TT0NfSU1YX1BDTV9GSVEgYW5kIFNORF9TT0NfSU1YX1BDTV9ETUEgYnkg ZGVmYXVsdCBhZGRzIAp0b28gbXVjaCBvdmVyaGVhZCB5b3UgY291bGQgYWRkIGJvb2xlYW4gc3Vi LW9wdGlvbnMgdGhhdCBhbGxvdyB0byAKZW5hYmxlL2Rpc2FibGUgc3VwcG9ydCBpbmRpdmlkdWFs bHkuCgotIExhcnMKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: lars@metafoo.de (Lars-Peter Clausen) Date: Tue, 29 Apr 2014 16:30:43 +0200 Subject: [alsa-devel] [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed In-Reply-To: <4275868.O962kiiyJa@wuerfel> References: <6606961.lAGLvkNsEj@wuerfel> <4270904.84oGcCXL4B@wuerfel> <535F8594.40609@metafoo.de> <4275868.O962kiiyJa@wuerfel> Message-ID: <535FB793.5050200@metafoo.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/29/2014 03:30 PM, Arnd Bergmann wrote: > On Tuesday 29 April 2014 12:57:24 Lars-Peter Clausen wrote: >> On 04/29/2014 12:37 PM, Arnd Bergmann wrote: >>> On Tuesday 29 April 2014 07:07:33 Alexander Shiyan wrote: >>>> Mon, 28 Apr 2014 23:12:14 +0200 ?? Arnd Bergmann : >>>>> On Tuesday 29 April 2014 00:35:41 Alexander Shiyan wrote: >>>>>> >>>>>> So, I don't understand why this error happen, as well as I can not >>>>>> reproduce this... >>>>> >>>>> It's probably CONFIG_SND_SOC_IMX_PCM_DMA=m and CONFIG_SND_SOC_FSL_SSI=y then. >>>>> What is the intended behavior in this case? Should CONFIG_SND_SOC_FSL_SSI >>>>> be forced to be a module as well? >>>> >>>> Hmm, yes... >>>> I thought that I had already solved a similar problem for the earlier >>>> version of the patch ... >>> >>> How about this? >> >> Having FSL_SSI/FSL_SPDIF, but not SND_SOC_IMX_PCM_DMA does not make sense on >> iMX. >> So how about: >> >> select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC >> >> and remove all the other 'select SND_SOC_IMX_PCM_DMA' statements. That's in >> my opinion much nicer. > > Yes, makes sense. Should I do another version of the patch? Yes. The patch should also add a select for SND_SOC_IMX_PCM_FIQ as that is used in the same way in the fsl_ssi driver. If anybody is afraid that selecting both SND_SOC_IMX_PCM_FIQ and SND_SOC_IMX_PCM_DMA by default adds too much overhead you could add boolean sub-options that allow to enable/disable support individually. - Lars