From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-arm-msm@vger.kernel.org,
Mona Hossain <mhossain@codeaurora.org>,
Hariprasad Dhalinarasimha <hnamgund@codeaurora.org>,
Zhen Kong <zkong@codeaurora.org>,
Niranjana Vishwanathapura <nvishwan@codeaurora.org>,
Rohit Vaswani <rvaswani@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms
Date: Tue, 29 Apr 2014 17:31:36 +0300 [thread overview]
Message-ID: <535FB7C8.3090302@mm-sol.com> (raw)
In-Reply-To: <20140428081805.GA15980@gondor.apana.org.au>
Thanks for the review!
On 04/28/2014 11:18 AM, Herbert Xu wrote:
> On Mon, Apr 14, 2014 at 03:48:40PM +0300, Stanimir Varbanov wrote:
>>
>> + } else if (IS_DES(flags)) {
>> + u32 tmp[DES_EXPKEY_WORDS];
>> +
>> + if (keylen != QCE_DES_KEY_SIZE)
>> + goto badkey;
>
> No need to check here since you've already set min_keysize and
> max_keysize correctly.
>
>> + } else if (IS_3DES(flags)) {
>> + if (keylen != DES3_EDE_KEY_SIZE)
>> + goto badkey;
>
> Ditto.
OK, I will delete those needless keylen checks.
--
regards,
Stan
next prev parent reply other threads:[~2014-04-29 14:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 12:48 [RFC PATCH v2 0/9] Add Qualcomm crypto driver Stanimir Varbanov
2014-04-14 12:48 ` [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation Stanimir Varbanov
2014-04-28 8:50 ` Herbert Xu
2014-04-29 14:38 ` Stanimir Varbanov
2014-04-30 0:03 ` Herbert Xu
2014-04-28 8:59 ` Herbert Xu
2014-04-30 16:35 ` Stanimir Varbanov
2014-05-08 21:57 ` Stanimir Vabanov
2014-05-13 11:06 ` Herbert Xu
2014-04-14 12:48 ` [RFC PATCH v2 2/9] crypto: qce: Add register defines Stanimir Varbanov
2014-04-14 12:48 ` [RFC PATCH v2 3/9] crypto: qce: Add dma and sg helpers Stanimir Varbanov
2014-04-14 12:48 ` [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms Stanimir Varbanov
2014-04-28 8:00 ` Herbert Xu
2014-04-29 14:24 ` Stanimir Varbanov
2014-04-28 8:18 ` Herbert Xu
2014-04-29 14:31 ` Stanimir Varbanov [this message]
2014-04-14 12:48 ` [RFC PATCH v2 5/9] crypto: qce: Adds sha and hmac transforms Stanimir Varbanov
2014-04-14 12:48 ` [RFC PATCH v2 6/9] crypto: qce: Adds infrastructure to setup the crypto block Stanimir Varbanov
2014-04-14 12:48 ` [RFC PATCH v2 7/9] crypto: qce: Adds Makefile to build the driver Stanimir Varbanov
2014-04-14 12:48 ` [RFC PATCH v2 8/9] crypto: qce: Build Qualcomm qce driver Stanimir Varbanov
2014-04-14 12:48 ` [RFC PATCH v2 9/9] ARM: DT: qcom: Add Qualcomm crypto driver binding document Stanimir Varbanov
2014-04-16 15:10 ` [RFC PATCH v2 0/9] Add Qualcomm crypto driver Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535FB7C8.3090302@mm-sol.com \
--to=svarbanov@mm-sol.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hnamgund@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhossain@codeaurora.org \
--cc=nvishwan@codeaurora.org \
--cc=rvaswani@codeaurora.org \
--cc=zkong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.